Skip to content

[ticket/15120] Semicolon missing#4731

Merged
Elsensee merged 1 commit intophpbb:masterfrom
Rishabh04-02:ticket/15120
Mar 11, 2017
Merged

[ticket/15120] Semicolon missing#4731
Elsensee merged 1 commit intophpbb:masterfrom
Rishabh04-02:ticket/15120

Conversation

@Rishabh04-02
Copy link
Contributor

@Rishabh04-02 Rishabh04-02 commented Mar 10, 2017

https://tracker.phpbb.com/browse/PHPBB3-15120
PHPBB3-15120

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-12345

@Rishabh04-02
Copy link
Contributor Author

@DavidIQ please review.

@Rishabh04-02 Rishabh04-02 mentioned this pull request Mar 10, 2017
4 tasks
@Crizz0
Copy link
Member

Crizz0 commented Mar 10, 2017

Why is this neccassary? There is nothing wrong without a missing semicolon. That is allowed in CSS.

@DavidIQ
Copy link
Member

DavidIQ commented Mar 10, 2017

@Crizz0 I think it's causing build errors elsewhere

@javiexin
Copy link
Contributor

@Crizz0 yes, it is causing every build in master to fail.
This is due to the use of stylelint #4622 that uncovered this case.
May be correct CSS, but does not follow coding standards (as set by stylelint).

Elsensee added a commit to Elsensee/phpbb that referenced this pull request Mar 11, 2017
@Elsensee Elsensee merged commit e077bd7 into phpbb:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants