[ticket/14970] Use stylelint.io in travis CI builds#4622
[ticket/14970] Use stylelint.io in travis CI builds#4622marc1706 merged 12 commits intophpbb:masterfrom
Conversation
|
Seems to run now. Thoughts @hanakin ? |
|
yeah there are going to be some changes that still need to happen to the stylelint config but should not effect this. It will provide a good test though to make sure its working |
|
Error / warning thrown by stylelint causes tests to fail as expected: https://travis-ci.org/phpbb/phpbb/jobs/190053358 |
travis/check-stylesheet.sh
Outdated
| # the docs/CREDITS.txt file. | ||
| # | ||
| set -e | ||
| set -x |
There was a problem hiding this comment.
removes it please, or add set +x just before sourcing nvm because the output is 1000 times too verbose
|
Builds still fail on incorrect input data: https://travis-ci.org/phpbb/phpbb/jobs/190623874 |
1ed0170 to
ed423f2
Compare
| "homepage": "https://github.com/phpbb/phpbb#readme", | ||
| "devDependencies": { | ||
| "stylelint": "^7.7.1" | ||
| } |
There was a problem hiding this comment.
need to add new dependency for future versions "stylelint-order": "^0.3.0"
phpBB/package.json
Outdated
| "author": "", | ||
| "license": "GPL-2.0", | ||
| "bugs": { | ||
| "url": "https://github.com/phpbb/phpbb/issues" |
There was a problem hiding this comment.
this should technically point to the tracker since we do not use issues
phpBB/package.json
Outdated
| "bugs": { | ||
| "url": "https://github.com/phpbb/phpbb/issues" | ||
| }, | ||
| "homepage": "https://github.com/phpbb/phpbb#readme", |
There was a problem hiding this comment.
this should probably point to .com
travis/check-stylesheet.sh
Outdated
| set +x | ||
|
|
||
| DB=$1 | ||
| TRAVIS_PHP_VERSION=$2 |
There was a problem hiding this comment.
I don't see any need for DB or TRAVIS_PHP_VERSION
PHPBB3-14970
PHPBB3-14970
PHPBB3-14970
PHPBB3-14970
PHPBB3-14970
PHPBB3-14970
9196a9d to
fa2d1eb
Compare
|
Updated |
PHPBB3-14970
|
👍 |
| npm install > /dev/null | ||
| set -x | ||
| stylelint --config ../.stylelintrc "styles/prosilver/theme/*.css" | ||
| fi |
There was a problem hiding this comment.
probably need to lint the admin css as well to ensure complete standards
There was a problem hiding this comment.
Yep, will add the admin css as well.
There was a problem hiding this comment.
Added the admin CSS but that line is commented now due to the large amount of issues that are noted. I think it's best to fix these issues in a separate PR.
There was a problem hiding this comment.
agree also since the I still need to update the linting rules file
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-14970