[ticket/14976] Convert all ems to px#4626
[ticket/14976] Convert all ems to px#4626marc1706 merged 15 commits intophpbb:masterfrom hanakin:ticket/14976
Conversation
|
rdy for review |
phpBB/styles/prosilver/theme/cp.css
Outdated
| .nojs .tabs a span, | ||
| .nojs .minitabs a span { | ||
| letter-spacing: -0.5px; | ||
| letter-spacing: -0.031em; |
There was a problem hiding this comment.
Any reason why you changed this from px to em then?
There was a problem hiding this comment.
letter-spacing and word-spacing are the only property exceptions to not using em as they have to be fractional which is not possible with px. It is also safe to use them for them as you never inherit this its always explicitly set at the child and not the parent
| padding-right: 2px; | ||
| } | ||
|
|
||
| /* Not used anywhere */ |
There was a problem hiding this comment.
Might be left over from previously when we had a different type of dropdown for the sort options.
There was a problem hiding this comment.
possibly, but its always been display-options for that https://github.com/phpbb/phpbb/blame/3.0.x/phpBB/styles/prosilver/template/viewtopic_body.html#L227
|
Rdy! |
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
PHPBB3-14976
|
@phpbb/development-team this is ready pending errors |
|
Travis has provided you with exactly one error: https://travis-ci.org/phpbb/phpbb/jobs/286664050#L628 |
| margin-left: 176px; | ||
| } | ||
|
|
||
| fieldset.fields1 dd { |
There was a problem hiding this comment.
Wouldn't it be cleaner to have the border-left-width definition in here instead of directly overwriting the margin-left for fieldset.fields1 dd from above it?
There was a problem hiding this comment.
Yeah saw that will fix it tonight
PHPBB3-14976
PHPBB3-14976
|
@marc1706 should be good now |
|
"What does this button do?" 😃 |
This should be the last major overhaul for standardization but the one that may require the largest review so I want to get it up early to allow ample time for critiques and bug fixes
to be merged after #4726, #4727
Checklist:
PHPBB3-14976
https://tracker.phpbb.com/browse/PHPBB3-14976