Skip to content

[ticket/14928] fixing validity#4730

Closed
Rishabh04-02 wants to merge 1 commit intophpbb:masterfrom
Rishabh04-02:ticket/14928
Closed

[ticket/14928] fixing validity#4730
Rishabh04-02 wants to merge 1 commit intophpbb:masterfrom
Rishabh04-02:ticket/14928

Conversation

@Rishabh04-02
Copy link
Contributor

@Rishabh04-02 Rishabh04-02 commented Mar 9, 2017 •
edited
Loading

https://tracker.phpbb.com/browse/PHPBB3-14928
file changed - phpBB/language/en/cli.php
14928

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-12345

@CHItA CHItA added this to the 3.3.0-a1 milestone Mar 14, 2017
@CHItA
Copy link
Member

CHItA commented Mar 14, 2017

LGTM, thanks for the contribution.

@phpbb/development-team @phpbb/native

@Nicofuma Nicofuma modified the milestones: 3.2.2, 3.3.0-a1, 3.2.1 Mar 19, 2017
@Nicofuma
Copy link
Member

Nicofuma commented Mar 19, 2017

Merged in 3.2.x by ed2d086

@Nicofuma Nicofuma closed this Mar 19, 2017
@Rishabh04-02
Copy link
Contributor Author

Rishabh04-02 commented Mar 20, 2017

@Nicofuma : I've a little confusion, This pr is shown to be merged when visiting Merged with master
But unlike my other pr's here at the top its shown Closed While at my other pr's when they're merged at the top its shown Merged. Just curious.

@Nicofuma
Copy link
Member

Nicofuma commented Mar 20, 2017

It is shown as Closed because I had to rebase your PR before merging it into 3.2.x
Therefor the commit merged is not the same as the one of your PR and Gthub can not detect it.

@Rishabh04-02
Copy link
Contributor Author

Rishabh04-02 commented Mar 20, 2017

Actually I am an aspiring candidate for GSOC-2017 & want to apply in your organization.
So in proposal how can i mention pr as while reviewing the person can find it closed instead of merged?
Will that affect my proposal in anyway?

@CHItA
Copy link
Member

CHItA commented Mar 20, 2017

Nope, a) we will know that it was merged, b) AFAIK you don't need to be merged, if you worked on something that's a plus.

@Rishabh04-02
Copy link
Contributor Author

Rishabh04-02 commented Mar 20, 2017

Thanks @CHItA for clearing my doubts.

@Rishabh04-02
Copy link
Contributor Author

Rishabh04-02 commented Apr 29, 2017 •
edited
Loading

The issue which is solved in this PR, has been reopened here - PHPBB3-14928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CHItA CHItA CHItA approved these changes

Assignees

No one assigned

Labels

3.2 (Rhea)

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Rishabh04-02 @CHItA @Nicofuma