Merged
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
dave-tucker
requested changes
May 6, 2021
dave-tucker
approved these changes
May 6, 2021
Collaborator
Author
|
Thanks @dave-tucker |
Member
|
I personally have a strong preference on having the details in the git commit message rather than the PR summary. I can do |
Collaborator
Author
|
I don't understand Rolf. To what do you refer, the git commit message vs PR? |
Member
has none of the details you mentions above, like
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
Small change: have linuxkit/alpine calculate and carry its own hash, and use it from makefile, rather than calculating it in the Makefile. As a nice side effect, it allows us to be working inside any linuxkit/alpine image and know precisely what tag ran it.
Also,
docker buildsetsTARGETARCHfor us, which gets rid of a few lines in theMakefileFinally, if we ever change how we calculate it, that change will be inherent inside the image build itself
- How I did it
Move some logic from
tools/alpine/Makefiletotools/alpine/Dockerfile, and then changeMakefileto consume it.- How to verify it
Run it.
- Description for the changelog
linuxkit/alpine carries its own calculated hash tag with it.