Add a linter to check rtf test cases are using latest images#3661
Add a linter to check rtf test cases are using latest images#3661dave-tucker wants to merge 3 commits intolinuxkit:masterfrom
Conversation
This commit improves the hash function to include the Dockerfile and, like tools/alpine, persists the last hash in version.$(ARCH). This allows the addition of a `show-tag` target which will retrieve the tag from the last time the package was pushed. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
@rn @deitch I've just noticed that Also this will fail as it found that the |
| pr: check-deps test-pr | ||
| PACKAGES=$(dir $(shell find ../pkg ./pkg ../tools/ -maxdepth 2 -mindepth 2 -type f -name build.yml)) | ||
| TOOLS=$(dir $(shell find ../tools -maxdepth 2 -mindepth 2 -type f -name Makefile)) | ||
| echo "ERROR: expected latest tag ${full_tag}" |
There was a problem hiding this comment.
ignore this copypasta will fix on next push.
|
@dave-tucker wrote:
I think (I have been digging more deeply into alpine lately) because they use different algorithms:
If you want to see it in action, I have a small PR open to simplify it and the build process. It doesn't change the logic, just easier to get at and have alpine carry it along the way, see #3650 . Actually, that is so small and simple that it should get approved and merged quickly. |
|
@deitch, |
|
I don't disagree. I don't know what the story is with the guestfs one. |
|
I think |
- What I did
Added a shell script to ensure that all the tests use up-to-date images
- How I did it
Shell script magic and adjusted Makefile.
Also changed the hashing logic for tools/guestfs
- How to verify it
CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
