Merged
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Collaborator
Author
|
Thanks. Glad to get this regression out of the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher avi@deitcher.net
- What I did
In PR #3650 we moved the logic for calculating the hash for an arch-specific alpine image from inside
tools/alpine/Makefileto insidetools/alpine/Dockerfileand then consumed it. This was a good idea, but the implementation had two issues:TARGETARCHdid so in a way that left it as a literal${TARGETARCH}rather than interpolated correctly by the Dockerfile/etc/alpine-hash, which implied that it was the generic, multi-arch index, when really it is just the arch-specific oneThis PR corrects both of the above. It ensures that
TARGETARCHis interpolated by the Dockerfile, and it saves the file as/etc/alpine-hash-arch.This does not resolve the question of having an alpine image carry the multi-arch tag, likely in
/etc/alpine-hash, as that is a more complicated issue, and something we never had before (one step up). Instead, it just fixes a regression from #3650 so that this all works correctly.If I can figure out a sane way to get
/etc/alpine-hashbefore this PR goes in, I will update this PR, else it will be the subject of a separate one (potentially).- How I did it
Modified
tools/alpine/Makefileandtools/alpine./Dockerfile- How to verify it
CI is your friend. Also, you can do what I did, which is to build
linuxkit/alpinemanually on different platforms and check the content of/etc/alpine-hash-arch.- Description for the changelog
Fix alpine hash file generation