Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts#2015

Merged
JoeWang1127 merged 1 commit into
mainfrom
feat/filter-out-legacy-yaml
Sep 20, 2023
Merged

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts#2015
JoeWang1127 merged 1 commit into
mainfrom
feat/filter-out-legacy-yaml

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

Fixes #2014 ☕️

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 20, 2023
@JoeWang1127

JoeWang1127 commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

Test locally with proto_path_list:

google/cloud/videointelligence/v1 google-cloud-videointelligence-v1-java

@JoeWang1127
JoeWang1127 marked this pull request as ready for review September 20, 2023 15:44
@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@JoeWang1127
JoeWang1127 merged commit 1ad5ec0 into main Sep 20, 2023
@JoeWang1127
JoeWang1127 deleted the feat/filter-out-legacy-yaml branch September 20, 2023 17:16
@release-please release-please Bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@blakeli0 blakeli0 Awaiting requested review from blakeli0
2 more reviewers
@meltsufin meltsufin meltsufin approved these changes
@diegomarquezp diegomarquezp diegomarquezp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter *.legacy.yaml when parsing java_gapic_opt from proto_path

3 participants

@JoeWang1127 @meltsufin @diegomarquezp