server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter#32106
Merged
ctiller merged 44 commits intogrpc:masterfrom Feb 1, 2023
Conversation
19ddfb2 to
e0b7519
Compare
markdroth
reviewed
Jan 17, 2023
Member
markdroth
left a comment
There was a problem hiding this comment.
This looks like a good start!
Please let me know if you have any questions. Thanks!
markdroth
reviewed
Jan 21, 2023
Member
markdroth
left a comment
There was a problem hiding this comment.
This is moving in the right direction!
Please let me know if you have any questions. Thanks!
markdroth
reviewed
Jan 23, 2023
Member
markdroth
left a comment
There was a problem hiding this comment.
This is getting closer!
Please let me know if you have any questions. Thanks!
Member
|
It looks like you did the merge with master wrong. All of the unrelated PRs that you merged in were somehow merged from the original commits in their branches, not from master, so they're showing up as part of the changes in this PR. To fix this, please do something like this: |
markdroth
reviewed
Jan 25, 2023
Member
markdroth
left a comment
There was a problem hiding this comment.
Just one significant comment remaining, which is the one about the synchronization and caching approach in ServerMetricRecorder. The other comments are more minor things.
Please let me know if you have any questions. Thanks!
yousukseung
added a commit
to yousukseung/grpc
that referenced
this pull request
Feb 3, 2023
…er-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" PR grpc#32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer. This reverts commit deb1e25.
yousukseung
added a commit
to yousukseung/grpc
that referenced
this pull request
Feb 3, 2023
…er-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" This reverts commit deb1e25.
yousukseung
added a commit
to yousukseung/grpc
that referenced
this pull request
Feb 3, 2023
PR grpc#32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer.
yousukseung
added a commit
that referenced
this pull request
Feb 3, 2023
…er-call reporting from a C++ interceptor to a C-core filter (#32106)" (#32272)" (#32279) * Revert "Revert "server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter (#32106)" (#32272)" This reverts commit deb1e25. * Fix by caching call metric recording stuff in async request PR #32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer. * copyright headers fixed * clang fixes.
ctiller
added a commit
that referenced
this pull request
Feb 3, 2023
ctiller
added a commit
that referenced
this pull request
Feb 3, 2023
yousukseung
added a commit
to yousukseung/grpc
that referenced
this pull request
Feb 5, 2023
…r API and move per-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" (grpc#32279)" (grpc#32293)" This reverts commit 1f96069.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…g from a C++ interceptor to a C-core filter (grpc#32106) * backend metric sampling * Comments addressed. * More comments addressed. * Pushing changes left behind locally. * Removed empty lines * Update OrcaService to use ServerMetricRecorder (no named metrics yet) * Comments addressed. * More comments addressed * More comments addressed. * Comments fixed * Comments addressed. * Test fixed * make seq returned always up-to-date * skip atomic load when not cached * Fixed ABSL_GUARDED_BY * Comments addressed except client_lb_end2end_test * test updated * Comments addressed * BUILD fix. * BackendMetricDataState moved to a separate header * comments addressed * Fixed clang and buildifier errors * More sanity check errors fixed. * Fixed xds tests * Ran generate_projects.sh * Comments addressed * comments addressed. * generate project * Build fixed * generate project * sanity check errors fixed * test fixed * Backup poller period override moved to main() * Also move cfstream override * Clang fixes, sanitize * generate_projects.sh * portable print format fix * Removed outdated comment
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272) This reverts commit c7f641d.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…er-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" (grpc#32279) * Revert "Revert "server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" This reverts commit deb1e25. * Fix by caching call metric recording stuff in async request PR grpc#32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer. * copyright headers fixed * clang fixes.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…d move per-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" (grpc#32279)" (grpc#32293) This reverts commit 4475e74.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
grpc#32301) * Revert "Revert "Revert "Revert "server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" (grpc#32279)" (grpc#32293)" This reverts commit 1f96069. * Do not create CallMetricRecorder if call is null.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…g from a C++ interceptor to a C-core filter (#32106) * backend metric sampling * Comments addressed. * More comments addressed. * Pushing changes left behind locally. * Removed empty lines * Update OrcaService to use ServerMetricRecorder (no named metrics yet) * Comments addressed. * More comments addressed * More comments addressed. * Comments fixed * Comments addressed. * Test fixed * make seq returned always up-to-date * skip atomic load when not cached * Fixed ABSL_GUARDED_BY * Comments addressed except client_lb_end2end_test * test updated * Comments addressed * BUILD fix. * BackendMetricDataState moved to a separate header * comments addressed * Fixed clang and buildifier errors * More sanity check errors fixed. * Fixed xds tests * Ran generate_projects.sh * Comments addressed * comments addressed. * generate project * Build fixed * generate project * sanity check errors fixed * test fixed * Backup poller period override moved to main() * Also move cfstream override * Clang fixes, sanitize * generate_projects.sh * portable print format fix * Removed outdated comment
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…er-call reporting from a C++ interceptor to a C-core filter (#32106)" (#32272)" (#32279) * Revert "Revert "server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter (#32106)" (#32272)" This reverts commit deb1e25. * Fix by caching call metric recording stuff in async request PR #32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer. * copyright headers fixed * clang fixes.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support backend metric sampling and make orca intereptor a channel filter