Revert "Revert "server: introduce ServerMetricRecorder API and move p…#32278
Closed
yousukseung wants to merge 1 commit intogrpc:masterfrom
Closed
Revert "Revert "server: introduce ServerMetricRecorder API and move p…#32278yousukseung wants to merge 1 commit intogrpc:masterfrom
yousukseung wants to merge 1 commit intogrpc:masterfrom
Conversation
…er-call reporting from a C++ interceptor to a C-core filter (grpc#32106)" (grpc#32272)" PR grpc#32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer. This reverts commit deb1e25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er-call reporting from a C++ interceptor to a C-core filter (#32106)" (#32272)"
PR #32106 caused msan errors in some tests while de-referencing the server object where async calls are active after the server is destroyed. Instead cache the ServerMetricRecorder pointer.
This reverts commit deb1e25.