2.3.0 - #1455
2.3.0#1455
Conversation
|
Note: the patch for the CI failures is included in the security patches |
|
Hi @UlisesGascon — regarding the Windows CI failures on this release PR (windows-latest x Node 10-21): the root cause is the orphan-file-cleanup test added in 9c801c7 (GHSA-3p4h-7m6x-2hcm). On Windows with Node <= 21 the abort path cannot unlink the partial file because the write stream keeps the file handle open (EPERM), and the test's fixed 500ms wait + bare rimraf are also sensitive to that platform. That file has not been touched on main since it was introduced, so the fix is not in main yet. I opened #1456 ('fix: release write stream handle on aborted uploads'), which destroys the destination write stream on premature close and replaces the fixed 500ms waits with poll-until-empty. CI for that branch is fully green, including the previously failing windows Node 10-21 legs. |
95746dc to
4417e5b
Compare
2ad8b68 to
eef7444
Compare
4417e5b to
91464d6
Compare
What's included in the
CHANGELOG.mdWhat's Changed
New Contributors
Full Changelog: v2.2.0...main