test: add coverage for preservePath - #1454
Merged
UlisesGascon merged 1 commit intoAug 24, 2026
Merged
Conversation
UlisesGascon
approved these changes
Aug 24, 2026
UlisesGascon
left a comment
Member
There was a problem hiding this comment.
This was fast @kory-kaai! Great work!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1453.
preservePathhad no test coverage —grep -r preservePath test/returned nothing — even though it changes what consumers see infile.originalname. This adds the two cases described in the issue:preservePathunset): a file sent asfilename="a/b/c.txt"arrives withoriginalname === 'c.txt'preservePath: true: the same upload keepsoriginalname === 'a/b/c.txt'Both go through
util.submitFormlike the existing tests. The full client path is set withform-data'sfilepathoption, sincefilenameis passed throughpath.basenameinternally and so can't express the path segments this option exists to preserve.Verified the assertions actually exercise the option: forcing
preservePath: falseinlib/make-middleware.jsfails the second case with-c.txt/+a/b/c.txt, and it passes again once reverted.npm testgoes from 84 to 86 passing, andnpm run lintis clean. No source or existing test files are touched.