Skip to content

feat(cli): add p2p diagnostics to ping #14426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethanndickson merged 1 commit into from
Aug 28, 2024
Merged

feat(cli): add p2p diagnostics to ping #14426

ethanndickson merged 1 commit into from
Aug 28, 2024

Conversation

@ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 26, 2024 •
edited
Loading

First PR to address #14244.

Adds common potential reasons as to why a direct connection to the workspace agent couldn't be established to coder ping:

  • If the Coder deployment administrator has blocked direction connections (CODER_BLOCK_DIRECT).
  • If the client has no STUN servers within it's DERP map.
  • If the client or agent appears to be behind a hard NAT, as per Tailscale netInfo.MappingVariesByDestIP

Also adds a warning if the client or agent has a network interface below the 'safe' MTU for tailnet. This warning is always displayed at the end of a coder ping.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Aug 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently from 6b50ee0 to da189ae Compare August 26, 2024 08:43
ethanndickson
ethanndickson commented Aug 26, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently from 62ef172 to 5e7d212 Compare August 26, 2024 12:31
deansheather
deansheather reviewed Aug 27, 2024
View reviewed changes
deansheather
deansheather reviewed Aug 27, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch from 5e7d212 to c8a7222 Compare August 27, 2024 05:31
@ethanndickson ethanndickson marked this pull request as ready for review August 27, 2024 05:33
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently from b48a21d to 047e871 Compare August 27, 2024 05:41
deansheather
deansheather reviewed Aug 27, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch from 047e871 to 5db04cd Compare August 27, 2024 06:19
deansheather
deansheather approved these changes Aug 27, 2024
View reviewed changes
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch from 5db04cd to df1bee7 Compare August 27, 2024 07:00
@ethanndickson ethanndickson mentioned this pull request Aug 27, 2024
Merged
@ethanndickson ethanndickson force-pushed the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch from df1bee7 to 9117628 Compare August 28, 2024 02:54
@ethanndickson ethanndickson merged commit 8c15192 into main Aug 28, 2024
@ethanndickson ethanndickson deleted the 08-26-feat_cli_add_p2p_diagnostics_to_ping branch August 28, 2024 05:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deansheather deansheather deansheather approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@ethanndickson ethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanndickson @deansheather