feat(cli): add aws check to ping p2p diagnostics #14450
Merged
+426
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
commented
Aug 27, 2024
|
|
||
| // CheckIP checks if the given IP address is an AWS IP. | ||
| func (r *AWSIPRanges) CheckIP(ip netip.Addr) (bool, error) { | ||
| if ip.IsLoopback() || ip.IsLinkLocalMulticast() || ip.IsLinkLocalUnicast() || ip.IsPrivate() { |
Member
Author
There was a problem hiding this comment.
We shouldn't be given these IP classes in coder ping, but this is in case we ever wanted to re-use this util.
ethanndickson
commented
Aug 27, 2024
deansheather
approved these changes
Aug 27, 2024
df1bee7 to
9117628
Compare
41ab80f to
a92e814
Compare
a92e814 to
15438e6
Compare
9117628 to
8c15192
Compare
461723e to
788ff3a
Compare
spikecurtis
reviewed
Aug 29, 2024
Contributor
spikecurtis
left a comment
There was a problem hiding this comment.
So, not necessarily in this PR, but part of this work is that every diagnostic check should have a corresponding page/section in our docs and we should include the link in the CLI output
a la
You are connected via a DERP relay, not directly, peer-to-peer (p2p).
Possible client-side issues with direct connection:
- We detected an endpoint firewall that could be blocking UDP from the agent.
https://docs.coder.com/<whatever>
788ff3a to
9ccec94
Compare
Member
Author
|
New output format: Fixing the test I broke... |
ethanndickson
commented
Aug 29, 2024
spikecurtis
reviewed
Aug 29, 2024
spikecurtis
reviewed
Aug 29, 2024
spikecurtis
approved these changes
Aug 29, 2024
e162ec9 to
2e08d19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues to address #14244.
If the client or agent's public IP is within an AWS range,
coder pingwill now report that it is behind a hard NAT, which may impede forming a direct connection.Additionally informs if the client or agent was unable to contact a STUN server over UDP, if the DERP map contains a STUN server.
Output format: