fix(animations): remove finish listener once player is destroyed#51136
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(animations): remove finish listener once player is destroyed#51136arturovt wants to merge 1 commit intoangular:mainfrom
finish listener once player is destroyed#51136arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
4c2cc25 to
1171fea
Compare
This commit removes the `finish` listener from the Animation object once the animation is finished, effectively resolving a memory leak. Previously, the `finish` listener captured `this`, which prevented `this` from being garbage collected.
1171fea to
9b8cd13
Compare
JoostK
approved these changes
Nov 2, 2023
crisbeto
approved these changes
Nov 2, 2023
Member
|
This PR was merged into the repository by commit a02a745. |
Abseil-byte
pushed a commit
to Abseil-byte/angular
that referenced
this pull request
Nov 5, 2023
…ngular#51136) This commit removes the `finish` listener from the Animation object once the animation is finished, effectively resolving a memory leak. Previously, the `finish` listener captured `this`, which prevented `this` from being garbage collected. PR Close angular#51136
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#51136) This commit removes the `finish` listener from the Animation object once the animation is finished, effectively resolving a memory leak. Previously, the `finish` listener captured `this`, which prevented `this` from being garbage collected. PR Close angular#51136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
finishlistener from the Animation object once the animation is finished, effectively resolving a memory leak. Previously, thefinishlistener capturedthis, which preventedthisfrom being garbage collected.See the image below: