fix: YAML resource should support file URI starting with fttp://, http://, https://#846
Merged
Conversation
hervelemeur
suggested changes
Sep 6, 2022
Member
Author
|
So I messed up the git history with old xml change, I first need to clean this up |
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
lemeurherve
reviewed
Sep 10, 2022
lemeurherve
reviewed
Sep 10, 2022
lemeurherve
reviewed
Sep 10, 2022
lemeurherve
reviewed
Sep 10, 2022
lemeurherve
reviewed
Sep 10, 2022
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Member
Author
|
The e2e tests won't work until this PR is merged |
Contributor
|
FYI you can commit suggestions in batch ;) |
lemeurherve
pushed a commit
to lemeurherve/updatecli
that referenced
this pull request
Sep 10, 2022
lemeurherve
pushed a commit
to lemeurherve/updatecli
that referenced
this pull request
Sep 10, 2022
olblak
added a commit
that referenced
this pull request
Feb 1, 2023
* feat(yaml): implement spec.files for kind: yaml Follow-up of #490 Ref #435 * Add e2e test for yaml (#43) * Apply suggestions from code review Co-authored-by: Olivier Vernin <olivier@vernin.me> * chore: move test to e2e success folder * wip: first stab at files for condition too * Revert "wip: first stab at files for condition too" This reverts commit 957f21e. * restore comment, will be done in #729 * chore: replace deprecated sourceID field by sourceid * fix: e2e tests * breaking?: no error if the target content hasn't changed * Remove broken test file Signed-off-by: Olblak <me@olblak.com> * patch from main (with #846 included and adapted) * fix tests * Add missing jsonschema annotations Co-authored-by: Olivier Vernin <olivier@vernin.me> * fix: remove files field from expected autodiscovery tests results Omited if empty since previous commit * cleanup: remove non mandatory empty files field from chart examples * chore: more complete debug log with initial filePath * chore: add debug logs * Update pkg/plugins/resources/yaml/main.go * chore: add missing Test_TargetFromSCM test * Update pkg/plugins/resources/yaml/source.go Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com> * Update pkg/plugins/resources/yaml/main.go Co-authored-by: Olivier Vernin <olivier@vernin.me> * allow multiples files for 'condition' * update example with a condition checking multiple files * remove TODOs * remove unrelated changes * replace example by e2e test * correct check for s.file * Update pkg/plugins/resources/yaml/main.go --------- Signed-off-by: Olblak <me@olblak.com> Co-authored-by: Olivier Vernin <olivier@vernin.me> Co-authored-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #845
The current PR fixes the different file path scenario for the YAML resource
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement