Add spec.files for Condition and Target of kind yaml#650
Merged
Conversation
Follow-up of updatecli#490 Ref updatecli#435
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
olblak
reviewed
May 11, 2022
Co-authored-by: Olivier Vernin <olivier@vernin.me>
This reverts commit 957f21e.
spec.files for Target of kind yamlspec.files for Conditions and Target of kind yaml
spec.files for Conditions and Target of kind yamlspec.files for Condition and Target of kind yaml
dduportal
previously approved these changes
Jan 29, 2023
olblak
previously approved these changes
Feb 1, 2023
olblak
reviewed
Feb 1, 2023
spec.files for Condition and Target of kind yamlspec.files for Condition and Target of kind yaml
Member
|
Thanks @hervelemeur for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(yaml): implement spec.files for kind: yaml
Follow-up of #490
Ref #435
Allow to specify more than one file as target for
kind: yamlLike what have been done for
kind: file, the possibility to specify multiple files is only possible in thetargetsstage.Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement