feat(autodiscovery): align matching rule validation across all plugins#7867
Merged
olblak merged 2 commits intoMar 7, 2026
Conversation
Member
|
Thanks for the pull request. that's a big contribution |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-across-all-plugins
Member
|
Thank you for the pull request, that was a long but needed one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7628
Validate()method toMatchingRulesin all 17 autodiscovery plugins that were missing it (argocd,cargo,dockerfile,dockercompose,fleet,flux,githubaction,golang,helm,ko,kubernetes,maven,npm,nomad,precommit,updatecli,woodpecker)Validate()in each plugin'sNew()for bothIgnoreandOnlyrules, so invalid specs fail fast with a clear errorTestMatchingRulesValidateto each plugin's test file to prevent regressionsTest
Test plan
go test ./pkg/plugins/autodiscovery/... -run TestMatchingRulesValidate— all passgo build ./pkg/plugins/autodiscovery/...— no errorsgolang/TestDiscoverManifestsfailure is unrelated to this PR)Related
ignorespec #7461 — original bug report (helmfile)Additional Information
Behavior
A matching rule with no selectors defined (all fields empty/zero) is now rejected with an explicit error:
invalid ignore spec: rule 1 has no valid fields (path or images must be specified)
Previously, such rules were silently accepted and resulted in 0 discoveries.