You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A follow-up suggestion was to apply the same behavior to other autodiscovery plugins for consistency.
This is a proposal / tracking issue. If this is not desired, feel free to close it.
Goal
Align autodiscovery matching rule behavior across plugins:
A rule with no selectors defined (all fields empty/zero values) MUST NOT match.
Invalid specs should fail fast with a clear error when applicable.
Add/adjust unit tests to prevent regressions.
Proposed approach
Audit other autodiscovery plugins’ matching-rule implementations.
Prefer small PRs (one plugin per PR) to keep reviews easy.
Keep behavior unchanged for non-empty rules.
Checklist (draft)
Identify affected autodiscovery plugins and list them here (matchingRule.go / equivalent).
Add empty-rule guard / validation for plugin:
Add/adjust unit tests for plugin:
Repeat for remaining plugins
How to claim (help wanted)
Comment on this issue with the plugin/item you’ll take, e.g. “I’ll take ”.
To leave room for other contributors, I’ll wait a bit for volunteers, and if nobody picks it up I’m happy to start with the first item.
Context:
This is a proposal / tracking issue. If this is not desired, feel free to close it.
Goal
Align autodiscovery matching rule behavior across plugins:
Proposed approach
Checklist (draft)
How to claim (help wanted)
Comment on this issue with the plugin/item you’ll take, e.g. “I’ll take ”.
To leave room for other contributors, I’ll wait a bit for volunteers, and if nobody picks it up I’m happy to start with the first item.
Related:
ignorespec #7461