-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(typescript-eslint): export util types (close #10848) #10849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, @Mister-Hope! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 232f260
☁️ Nx Cloud last updated this comment at |
Switching this PR to draft pending issue triage. |
|
Noting that this issue is now accepting PRs, so we can unblock this PR. (thanks to @ntdiary for bringing this to our attention in #10893 (comment)) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10849 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 506 506
Lines 51394 51394
Branches 8482 8482
=======================================
Hits 46735 46735
Misses 4646 4646
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
5c1a159
into
typescript-eslint:main

PR Checklist
Overview
This adds export for a namespace
TSLintwhich contain types used in tslint.The main reason is that as the documentation suggests using tslint stricter types: https://typescript-eslint.io/getting-started#step-2-configuration, people may need to implicitly mark codes to these types in their own flag config, as auto-infer may contain "loose types" (e.g.:
stringinstead of'a' | 'b') that triggers ts errors.For examples,see #10848