Skip to content

Conversation

@Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Feb 19, 2025

PR Checklist

Overview

This adds export for a namespace TSLint which contain types used in tslint.

The main reason is that as the documentation suggests using tslint stricter types: https://typescript-eslint.io/getting-started#step-2-configuration, people may need to implicitly mark codes to these types in their own flag config, as auto-infer may contain "loose types" (e.g.: string instead of 'a' | 'b') that triggers ts errors.

For examples,see #10848

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Mister-Hope!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 232f260
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68da94db61c7f40008b93e97
😎 Deploy Preview https://deploy-preview-10849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Feb 19, 2025

View your CI Pipeline Execution ↗ for commit 232f260

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 22s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 58s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 14s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 13s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-29 14:24:08 UTC

@JoshuaKGoldberg
Copy link
Member

Switching this PR to draft pending issue triage.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft February 19, 2025 12:18
@kirkwaiblinger
Copy link
Member

Noting that this issue is now accepting PRs, so we can unblock this PR.

(thanks to @ntdiary for bringing this to our attention in #10893 (comment))

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (9530e02) to head (232f260).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10849   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51394    51394           
  Branches     8482     8482           
=======================================
  Hits        46735    46735           
  Misses       4646     4646           
  Partials       13       13           
Flag Coverage Δ
unittest 90.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 29, 2025 15:00
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5c1a159 into typescript-eslint:main Oct 6, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: export types in typescript-eslint package

3 participants