-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
PHP CS Fixer: enable static_lambda #62783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
keradus
wants to merge
61
commits into
symfony:8.1
Choose a base branch
from
keradus:8.1_static_lambda
base: 8.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,546
−1,543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, one less thing to be patched randomly :)
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2025
This PR was submitted for the 7.4 branch but it was merged into the 7.3 branch instead. Discussion ---------- [JsonPath] fix calling non-static method statically | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes-ish | New feature? | no <!-- if yes, also update src/**/CHANGELOG.md --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fix compiler complaints | License | MIT if [lambda would be declared as static](#62783), calling non-static method from it would fail with the following error: > Error: Non-static method Symfony\Component\JsonPath\JsonCrawler::normalizeStorage() cannot be called statically let's not call non-static method statically. Commits ------- 22db41e src/Symfony/Component/JsonPath - fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by https://github.com/symfony/symfony/pull/62762/changes#r2622285457
DRAFT, as not applied to whole repo, only to one bridge to show example outpuut.
if you like the change, i can apply to whole repo
I suggest to see what will fail, revert such package, merge the rest.
then, handle other packages in separated PRs