PHP CS Fixer: enable static_lambda #62783
Open
+1,546
−1,543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Nice one, one less thing to be patched randomly :)
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2025
This PR was submitted for the 7.4 branch but it was merged into the 7.3 branch instead. Discussion ---------- [JsonPath] fix calling non-static method statically | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes-ish | New feature? | no <!-- if yes, also update src/**/CHANGELOG.md --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fix compiler complaints | License | MIT if [lambda would be declared as static](#62783), calling non-static method from it would fail with the following error: > Error: Non-static method Symfony\Component\JsonPath\JsonCrawler::normalizeStorage() cannot be called statically let's not call non-static method statically. Commits ------- 22db41e src/Symfony/Component/JsonPath - fix
Member
Author
|
most component looks ready. few components needs more zoom-in and will take some time for me to catch up there. For now, reverted those componentss in this PR (last commits). perhaps, we can merge all the rest to avoid conflicts , @nicolas-grekas ?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by https://github.com/symfony/symfony/pull/62762/changes#r2622285457
DRAFT, as not applied to whole repo, only to one bridge to show example outpuut.
if you like the change, i can apply to whole repo
I suggest to see what will fail, revert such package, merge the rest.
then, handle other packages in separated PRs