Skip to content

devtools: Implement function preview in console#44233

Merged
atbrakhi merged 1 commit into
servo:mainfrom
eerii:function-preview
Apr 15, 2026
Merged

devtools: Implement function preview in console#44233
atbrakhi merged 1 commit into
servo:mainfrom
eerii:function-preview

Conversation

@eerii

@eerii eerii commented Apr 15, 2026

Copy link
Copy Markdown
Member

Testing: Added new tests for console array and function previews
Part of: #39858
Depends on: #44196

image

@eerii

eerii commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

Now we show function names when logging in the console. We can't easily get argument names, since we don't access the debugger API when doing console log, so as a fallback we show placeholders for the number of arguments. In the future, we would need to expose more things in mozjs.

Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: eri <eri@igalia.com>
@eerii eerii force-pushed the function-preview branch from 589fcfc to 24a1296 Compare April 15, 2026 11:56
@eerii eerii marked this pull request as ready for review April 15, 2026 11:57
@eerii eerii requested a review from gterzian as a code owner April 15, 2026 11:57
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 15, 2026
@eerii eerii requested a review from atbrakhi April 15, 2026 11:57
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 15, 2026
@atbrakhi atbrakhi added this pull request to the merge queue Apr 15, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 15, 2026
Merged via the queue into servo:main with commit d37e6f1 Apr 15, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 15, 2026
@eerii eerii mentioned this pull request Apr 16, 2026
37 tasks
@eerii eerii deleted the function-preview branch May 20, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants