devtools: implement ArrayPreview in console#44196
Merged
Merged
Conversation
Co-authored-by: eri <eri@igalia.com> Signed-off-by: atbrakhi <atbrakhi@igalia.com>
eerii
approved these changes
Apr 14, 2026
simonwuelker
left a comment
Member
There was a problem hiding this comment.
Can you write a test for this? We have existing tests for console.log.
Member
Author
ofcourse! I was thinking about adding it in the function preview that we are working on! But we can add it here too. |
Member
Author
|
@simonwuelker we ended up adding tests in #44233 that add support for function preview in the console, as we also made some structural changes there! I will try to land this, as #44233 depends on it :) |
Member
Alright, thank you! |
simartin
added a commit
to simartin/servo
that referenced
this pull request
Apr 15, 2026
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Testing: Added new tests for console array and function previews Part of: #39858 Depends on: #44196 <img width="934" height="388" alt="image" src="https://github.com/user-attachments/assets/8589ef9c-7a58-47dd-83dd-4f66607125fe" /> Signed-off-by: eri <eri@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show preview of
ArrayItemsin consoleTesting: Current tests are passing
Fixes: Part of #39858