Update to react-native 0.79 - #6607
Merged
Merged
Conversation
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
3 times, most recently
from
May 1, 2025 03:24
0f0b912 to
e28145c
Compare
walmat
reviewed
May 1, 2025
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
from
May 12, 2025 21:16
0fc2f71 to
ce5683b
Compare
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
from
May 30, 2025 15:52
23c079a to
84e7a74
Compare
janicduplessis
commented
Jun 2, 2025
|
|
||
| const conditionalProps = shouldUseFasterImage | ||
| ? { | ||
| key: `${typeof source === 'object' && source.uri ? source.uri : ''}` || undefined, |
Contributor
Author
There was a problem hiding this comment.
Key cannot be spread like this anymore in React 19
janicduplessis
marked this pull request as ready for review
June 2, 2025 16:14
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
3 times, most recently
from
June 3, 2025 03:24
601bdb3 to
903386e
Compare
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
from
June 4, 2025 20:11
36efdac to
adb9503
Compare
natew
reviewed
Jun 10, 2025
| +++ b/node_modules/react-native-animateable-text/lib/typescript/src/index.d.ts | ||
| @@ -1,4 +1,4 @@ | ||
| -declare const AnimateableText: import("react").FunctionComponent<import("react-native-reanimated").AnimateProps<Omit<import("react-native").TextProps, "children"> & { | ||
| +declare const AnimateableText: import("react").FunctionComponent<import("react-native-reanimated").AnimateProps<import("react-native").TextProps & { |
Contributor
There was a problem hiding this comment.
just curious - why do we need to stop removing children type?
Contributor
Author
There was a problem hiding this comment.
If I remember correctly this is due to a type change in React types that no longer automatically adds children. If we omit children here then the resulting type no longer had it.
Contributor
Author
There was a problem hiding this comment.
Possibly the React.FunctionComponent type
Member
natew
reviewed
Jun 12, 2025
| {...props} | ||
| key={`${typeof source === 'object' && source.uri ? source.uri : ''}` || undefined} | ||
| onError={this.props.onError} | ||
| onLoad={undefined} |
Contributor
There was a problem hiding this comment.
i suppose overwriting onLoad to undefined was intended 🤔 doubtful but we could leave it to err on the side of safety
Contributor
Author
There was a problem hiding this comment.
Yea also not sure, just kind of ported the existing code 1 for 1 just in case it is actually needed.
natew
reviewed
Jun 12, 2025
natew
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, and glad actually there's not so many js-level changes needed here which is great.
My two questions are:
One, I noticed there's quite a few propTypes left still in .js files, do we need to remove these?
Smaller, but I noticed we have old React 18 types in the design system docs. cc @christianbaroni do we want to update that alongside this?
Minus those the code looks good, going to test it on-device now.
Contributor
Author
|
For prop types I think I saw there are codemods around to convert it to typescript types so I wanted to keep them around if we want to do that eventually. They are just no longer checked, but don’t cause any issues. |
Contributor
|
Having trouble getting pods to install: And then: |
Contributor
|
Ah yea this is just some weird Pods cache thing, not sure if we can detect/clear it automatically but fixed on my end by clearing it. |
Contributor
Author
|
Updated to add --client-logs flag to get logs in console back
|
janicduplessis
force-pushed
the
@janic/upgrade-rn
branch
from
June 13, 2025 21:57
8cc6d51 to
930754c
Compare
Member
Contributor
Author
|
Conflicts fixed |
natew
approved these changes
Jun 16, 2025
natew
left a comment
Contributor
There was a problem hiding this comment.
Code lgtm, did a basic build and tested my wallet and a few areas.
ibrahimtaveras00
suggested changes
Jun 17, 2025
ibrahimtaveras00
left a comment
Contributor
There was a problem hiding this comment.
Found some UX issues and a crash
https://linear.app/rainbow/issue/APP-2759/qa-bug-epic-for-rn-upgrade
Member
Member
Contributor
Author
|
Here's a quick summary of the last changes:
|
Member
Member
janicduplessis
commented
Jul 29, 2025
| */ | ||
| export function getLuminanceWorklet(color: string): number { | ||
| 'worklet'; | ||
| const processedColor = processColor(color); |
Contributor
Author
There was a problem hiding this comment.
Do you prefer to keep the color validations? Only thing is would lead to double processing.
From my testing, passing an invalid color to convertToRGBA returns a black color
Member
Member
Member
janicduplessis
commented
Aug 4, 2025
| } | ||
|
|
||
| export const ApplyShadow = React.forwardRef(({ backgroundColor, children: child, shadows }: ApplyShadowProps, ref: React.Ref<any>) => { | ||
| export const ApplyShadow = ({ backgroundColor, children: child, shadows }: ApplyShadowProps) => { |
Contributor
Author
There was a problem hiding this comment.
There was some new warnings (prob because of the react upgrade) related to forwardRef ref param not being used. For this component if we are in the case if (!shadows) return child; the ref is not used. I noticed we actually never pass ref to this component so I just removed the forward ref.
janicduplessis
commented
Aug 4, 2025
| ); | ||
|
|
||
| if (IS_TEST || (IS_ANDROID && !enableOnAndroid)) return children; | ||
| if (IS_TEST || (IS_ANDROID && !enableOnAndroid)) { |
Contributor
Author
There was a problem hiding this comment.
We need to make sure to apply containerStyle in this case. This wasn't a regression from this PR, but included the fix here since it is pretty simple.
janicduplessis
commented
Aug 4, 2025
| if (!child) return null; | ||
| return ( | ||
| <> | ||
| <Fragment key={index}> |
Contributor
Author
There was a problem hiding this comment.
Fix a missing key warning.
janicduplessis
commented
Aug 4, 2025
|
|
||
| const TruncatedENS = ({ ens, truncationLength, ...props }, ref) => { | ||
| const text = useMemo( | ||
| const text = React.useMemo( |
Contributor
Author
There was a problem hiding this comment.
Not sure if this code is used, but use useMemo was not imported
janicduplessis
commented
Aug 4, 2025
| }; | ||
|
|
||
| const FreezableWebView = memo(React.forwardRef(FreezableWebViewComponent)); | ||
| const FreezableWebView = memo(FreezableWebViewComponent); |
Contributor
Author
There was a problem hiding this comment.
This component didn't use ref
Member
WoLewicki
reviewed
Aug 5, 2025
WoLewicki
left a comment
Contributor
There was a problem hiding this comment.
Left some comments, looks good overall!
| with: | ||
| cache-read-only: false | ||
|
|
||
| - run: cd rainbow-scripts && git checkout @janic/rn79 |
Contributor
There was a problem hiding this comment.
Do we want to leave it here or will it be removed before merge? Same for other occurences.
Contributor
Author
There was a problem hiding this comment.
No, we removed it right before merge, was only needed to get ci passing before we merge some prs in rainbow scripts
|
|
||
| ReactNativePerformance.onAppStarted() | ||
|
|
||
| #if RAINBOW_INTERNALS_ENABLED |
Contributor
There was a problem hiding this comment.
Does this work correctly in Swift? I can see it was taken from Internals module previously.
Contributor
Author
There was a problem hiding this comment.
I think this is actually never worked? It was also previously a preprocessor macro, but we never define it, it is a const in objc.
| return success | ||
| } | ||
|
|
||
| func hideSplashScreenAnimated() { |
Contributor
There was a problem hiding this comment.
Maybe we should just move it to RainbowSplashScreenManager ?
Contributor
Author
There was a problem hiding this comment.
Wanna open a PR for that one?
| "@types/prop-types": "15.7.14", | ||
| "@types/qs": "6.9.7", | ||
| "@types/react": "18.2.65", | ||
| "@types/react": "19.1.3", |
Contributor
There was a problem hiding this comment.
Should we sync this types minor version with React's one? (so 19.0.x)
| #if !TARGET_OS_OSX | ||
| - _displayLink.preferredFramesPerSecond = 120; // will fallback to 60 fps for devices without Pro Motion display | ||
| + if (@available(iOS 15.0, *)) { | ||
| + _displayLink.preferredFrameRateRange = CAFrameRateRangeMake(80, 120, 80); |
Contributor
Author
There was a problem hiding this comment.
@christianbaroni has some context about this one, trying to find it again, but I cant
| ARCHS_FLAG="-PreactNativeArchitectures=$ARCH" | ||
| fi | ||
|
|
||
| export SENTRY_DISABLE_AUTO_UPLOAD=true |
Contributor
There was a problem hiding this comment.
Was it meant to stay here?
Contributor
Author
There was a problem hiding this comment.
Yes, we don’t want to upload to sentry for e2e builds
Contributor
Author
There was a problem hiding this comment.
Not sure why I added it in this pr, but I think it makes sense
|
|
||
| const animatedTopColor = useDerivedValue(() => { | ||
| if (IS_TEST) return getColorValueForThemeWorklet(DEFAULT_BACKGROUND_COLOR, isDarkMode); | ||
| if (!_WORKLET || IS_TEST) return initialColors.top; |
Contributor
There was a problem hiding this comment.
When can it happen that this is not run as worklet?
olerass
added a commit
that referenced
this pull request
Feb 25, 2026
`@react-native/metro-config` is a build-time tool for configuring Metro, not a runtime dependency. It was originally added to `dependencies` during the RN 0.72 upgrade in #4955 (Feb 2023). When we upgraded to RN 0.79 in #6607 (Aug 2025), the correct `0.79.0` version was added to `devDependencies`, but the old `0.74.83` entry in `dependencies` was left behind. This change drops the stale entry. The `0.79.0` version in `devDependencies` is unchanged. No lockfile impact since yarn was already resolving via the devDeps entry. Ref FEPLAT-34.
olerass
added a commit
that referenced
this pull request
Apr 27, 2026
After bumping `@react-native-firebase/*` from 20.1.0 to 23.8.8 in #7319 (Apr 2026), iOS users see both a system banner AND a notifee-displayed local notification when a push arrives while the app is foregrounded. Pre-bump behavior was the notifee notification only. The cause is upstream: invertase/react-native-firebase#8786 (merged Feb 2026, shipped in v23.8.5) reordered RNFB's iOS `willPresent` delegate so the original AppDelegate handler is called first. Previously, RNFB consumed the one-shot `completionHandler` with its own default options (empty, since we don't have a `firebase.json`) before forwarding to AppDelegate, making AppDelegate's `completionHandler([.sound, .badge, .list, .banner])` a no-op. With the new order, AppDelegate wins and iOS now honors the full `[.sound, .badge, .list, .banner]` set the handler has been quietly asking for since #6607 (Aug 2025). This change updates AppDelegate's `willPresent` to call `completionHandler([])`, which suppresses all iOS-side presentation for the FCM remote when foregrounded. Rainbow's user-visible foreground notification UI is rendered by notifee from the separate `onMessage` JS handler (`src/notifications/foregroundHandler.ts` → `notifee.displayNotification`). Letting iOS also present the FCM payload would duplicate Notification Center entries and add badge increments that pre-bump prod never had. Returning `[]` matches the pre-RNFB-23.8.5 default of `UNNotificationPresentationOptionNone`. Background and killed-app notifications are unaffected since this delegate only runs in the foreground case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Here's a summary of the changes:
Screen recordings / screenshots
What to test
Everything 😅