fix(messaging, ios): prioritize delegate call order in willPresentNotification by WontakKim · Pull Request #8786 · invertase/react-native-firebase

WontakKim · 2025-12-01T03:41:12Z

Description

This PR fixes an issue where completionHandler in userNotificationCenter:willPresentNotification:withCompletionHandler: is called before the original delegate, preventing custom foreground notification presentation logic from working.

Related issues

Fixes [🐛] FirebaseMessaging(iOS): completionHandler called before originalDelegate in willPresentNotification #8754

Release Summary

Fixed iOS messaging to respect custom notification presentation logic by calling the original delegate before consuming the completionHandler.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS
- Other (macOS, web)
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

Tested Scenario:

Implemented custom willPresentNotification handler in AppDelegate to control notification presentation
Sent FCM notification while app is in foreground
Verified custom logic is now executed and controls notification display behavior

Before Fix:

Custom completion handler in AppDelegate was ignored
Notifications always displayed with library's default options

After Fix:

Custom completion handler in AppDelegate is respected
Developers can control whether/how to display foreground notifications
Default behavior preserved when no custom delegate exists

Code Example Tested:

// AppDelegate.m
- (void)userNotificationCenter:(UNUserNotificationCenter *)center
willPresentNotification:(UNNotification *)notification
withCompletionHandler:(void (^)(UNNotificationPresentationOptions))completionHandler {
  // Custom logic to determine notification presentation
  if (shouldShowNotification) {
    completionHandler(UNNotificationPresentationOptionBanner | 
                     UNNotificationPresentationOptionSound);
  } else {
    completionHandler(UNNotificationPresentationOptionNone);
  }
}

vercel · 2025-12-01T03:41:18Z

@wrtn-wontak is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2025-12-01T03:41:19Z

All committers have signed the CLA.

MichaelVerdon · 2025-12-01T14:21:10Z

Hi there @WontakKim looks good to me just fix the linter issues please and I will approve it and ensure the CLA is signed.

WontakKim · 2025-12-02T01:59:04Z

Hi @MichaelVerdon, I've signed the CLA docs and ran clang-format -i packages/messaging/ios/RNFBMessaging/RNFBMessaging+UNUserNotificationCenter.m. It seems to have changed some unnecessary lines. Could you please review my changes again?

WontakKim · 2025-12-15T10:43:34Z

Hi @MichaelVerdon , kindly reminds you to review this PR. Thanks.

github-actions · 2026-01-12T10:44:05Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

WontakKim · 2026-01-13T04:23:15Z

Hi @MichaelVerdon , It's been a while since I left my last comment, but I haven't received any response yet. Could you please check on this?

MichaelVerdon · 2026-01-26T12:50:31Z

Hi @MichaelVerdon , It's been a while since I left my last comment, but I haven't received any response yet. Could you please check on this?

Hi there apologies, I got caught up in alot of other work. I am looking now, thank you for your patience

MichaelVerdon · 2026-01-26T12:56:55Z

This looks good to me hapy to approve after CI runs on this one. Have you signed the CLA?

WontakKim · 2026-01-26T13:00:42Z

Hi, yes I have signed CLA.

mikehardy · 2026-01-26T13:33:21Z

Hi @WontakKim - the CLA bot doesn't seem to be registering the agreement - the typical cause of this is misaligned email address in github vs the commit. I see wontak-wtrn as the commit author but on this PR you are @WontakKim - so the CLA is not associating the author of the commit with the signer of the CLA.

https://github.com/cla-assistant/cla-assistant/blob/main/COMMON_ISSUES.md#you-are-not-able-to-sign-a-cla

You'll need to choose and either make sure the email address you configured in git for your commits is added to your github account or that you rewrite the commits and repush them after you reconfigure git to be the same email you use for your github account

mikehardy

looks good to me (thank you!) pending resolution of CLA signing issue

mikehardy · 2026-01-26T13:38:07Z

I am closing and reopening just to re-trigger CI checks, despite being an admin in the repo github CI is stuck for this PR

wontak-wrtn · 2026-01-27T00:56:51Z

I resigned CLA. @mikehardy thanks for guiding me.

…ification

mikehardy · 2026-01-27T02:52:10Z

android check failure was a flake, it passed on rerun but there was still a problem with ios for some reason
I pulled the PR locally and ran yarn lint:ios:fix, squashed that into the second commit, and pushed those back out to the branch

CI should re-run then ideally this is good to go, I'll check it in the morning

After bumping `@react-native-firebase/*` from 20.1.0 to 23.8.8 in #7319 (Apr 2026), iOS users see both a system banner AND a notifee-displayed local notification when a push arrives while the app is foregrounded. Pre-bump behavior was the notifee notification only. The cause is upstream: invertase/react-native-firebase#8786 (merged Feb 2026, shipped in v23.8.5) reordered RNFB's iOS `willPresent` delegate so the original AppDelegate handler is called first. Previously, RNFB consumed the one-shot `completionHandler` with its own default options (empty, since we don't have a `firebase.json`) before forwarding to AppDelegate, making AppDelegate's `completionHandler([.sound, .badge, .list, .banner])` a no-op. With the new order, AppDelegate wins and iOS now honors the full `[.sound, .badge, .list, .banner]` set the handler has been quietly asking for since #6607 (Aug 2025). This change updates AppDelegate's `willPresent` to call `completionHandler([])`, which suppresses all iOS-side presentation for the FCM remote when foregrounded. Rainbow's user-visible foreground notification UI is rendered by notifee from the separate `onMessage` JS handler (`src/notifications/foregroundHandler.ts` → `notifee.displayNotification`). Letting iOS also present the FCM payload would duplicate Notification Center entries and add badge increments that pre-bump prod never had. Returning `[]` matches the pre-RNFB-23.8.5 default of `UNNotificationPresentationOptionNone`. Background and killed-app notifications are unaffected since this delegate only runs in the foreground case.

WontakKim mentioned this pull request Dec 1, 2025

[🐛] FirebaseMessaging(iOS): completionHandler called before originalDelegate in willPresentNotification #8754

Closed

10 tasks

WontakKim changed the title ~~fix(messaging, ios): prioritize delegate call order in willPresentNot…~~ fix(messaging, ios): prioritize delegate call order in willPresentNotification Dec 1, 2025

github-actions Bot added the Needs Attention label Dec 2, 2025

mikehardy force-pushed the main branch 4 times, most recently from 38a52cd to 7af280b Compare December 8, 2025 20:10

github-actions Bot added Stale and removed Stale labels Jan 12, 2026

mikehardy added Blocked: Missing CLA Workflow: Pending Merge Waiting on CI or similar and removed Needs Attention labels Jan 26, 2026

mikehardy approved these changes Jan 26, 2026

View reviewed changes

mikehardy closed this Jan 26, 2026

mikehardy reopened this Jan 26, 2026

wontak-wrtn added 2 commits January 26, 2026 21:32

fix(messaging, ios): prioritize delegate call order in willPresentNot…

466c4aa

…ification

chore: apply clang-formatting

f2eae6c

mikehardy force-pushed the fix/ios-messaging-custom-completion-handler-support branch from 4cee1d5 to f2eae6c Compare January 27, 2026 02:51

mikehardy removed Blocked: Missing CLA Workflow: Pending Merge Waiting on CI or similar labels Jan 27, 2026

mikehardy merged commit d6f403a into invertase:main Jan 29, 2026
19 of 22 checks passed

olerass mentioned this pull request Apr 27, 2026

fix: duplicate foreground notification on iOS rainbow-me/rainbow#7391

Merged

jdcumpson mentioned this pull request Jun 11, 2026

[🐛] Broken change with PR #8786 - completionHandler is called twice when native implementation exists #9049

Closed

10 tasks

russellwheatley mentioned this pull request Jul 9, 2026

fix(messaging): willPresentNotification custom notification to work alongside default notification #9094

Merged

9 tasks

lnuvy mentioned this pull request Aug 27, 2026

[🐛] iOS: onMessage never fires in foreground when APNs payload has content-available: 0 #9228

Closed

10 tasks

Uh oh!

Conversation

WontakKim commented Dec 1, 2025 • edited by mikehardy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Release Summary

Checklist

Test Plan

Uh oh!

vercel Bot commented Dec 1, 2025

Uh oh!

CLAassistant commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelVerdon commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WontakKim commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WontakKim commented Dec 15, 2025

Uh oh!

github-actions Bot commented Jan 12, 2026

Uh oh!

WontakKim commented Jan 13, 2026

Uh oh!

MichaelVerdon commented Jan 26, 2026

Uh oh!

MichaelVerdon commented Jan 26, 2026

Uh oh!

WontakKim commented Jan 26, 2026

Uh oh!

mikehardy commented Jan 26, 2026

Uh oh!

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

mikehardy commented Jan 26, 2026

Uh oh!

wontak-wrtn commented Jan 27, 2026

Uh oh!

mikehardy commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WontakKim commented Dec 1, 2025 •

edited by mikehardy

Loading

CLAassistant commented Dec 1, 2025 •

edited

Loading

MichaelVerdon commented Dec 1, 2025 •

edited

Loading

WontakKim commented Dec 2, 2025 •

edited

Loading