Skip to content

Conversation

@JohnVillalovos
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 5, 2025 23:47
@JohnVillalovos JohnVillalovos marked this pull request as draft December 5, 2025 23:48
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/func_update_gitlab branch from a2ae9d6 to af0a1e8 Compare December 5, 2025 23:49
@JohnVillalovos JohnVillalovos changed the title tests(functional): update to GitLab 18.6 and fix issues found test(functional): update to GitLab 18.6 and resolve issues found Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the functional test infrastructure to use GitLab 18.6.1, upgrading from version 17.8.2. The changes include updating the Docker image version and fixing the container entrypoint to match changes in the newer GitLab image.

  • Updated GitLab Docker image from 17.8.2-ee.0 to 18.6.1-ee.0
  • Fixed Docker entrypoint script path to use /assets/init-container instead of the deprecated /assets/wrapper

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/functional/fixtures/.env Updates GitLab Docker image tag to version 18.6.1-ee.0
tests/functional/fixtures/docker-compose.yml Updates entrypoint script path to match the new GitLab image structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/func_update_gitlab branch 16 times, most recently from 5485137 to 7386870 Compare December 6, 2025 17:15
@JohnVillalovos JohnVillalovos marked this pull request as ready for review December 6, 2025 17:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/func_update_gitlab branch from 7386870 to 55fb124 Compare December 6, 2025 17:20
@JohnVillalovos JohnVillalovos requested a review from nejch December 6, 2025 17:20
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (4221195) to head (d82d267).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3309      +/-   ##
==========================================
+ Coverage   95.72%   95.75%   +0.03%     
==========================================
  Files          98       98              
  Lines        6052     6052              
==========================================
+ Hits         5793     5795       +2     
+ Misses        259      257       -2     
Flag Coverage Δ
api_func_v4 83.70% <ø> (+0.06%) ⬆️
cli_func_v4 78.68% <ø> (ø)
unit 90.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovos
Copy link
Member Author

@nejch It took a "few" iterations but I got things working. A review would be appreciated when you have some free time. Thanks in advance.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/func_update_gitlab branch from 55fb124 to 311a1af Compare December 8, 2025 15:07
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/func_update_gitlab branch from 311a1af to d82d267 Compare December 11, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants