-
Notifications
You must be signed in to change notification settings - Fork 675
test(functional): update to GitLab 18.6 and resolve issues found #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a2ae9d6 to
af0a1e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the functional test infrastructure to use GitLab 18.6.1, upgrading from version 17.8.2. The changes include updating the Docker image version and fixing the container entrypoint to match changes in the newer GitLab image.
- Updated GitLab Docker image from 17.8.2-ee.0 to 18.6.1-ee.0
- Fixed Docker entrypoint script path to use
/assets/init-containerinstead of the deprecated/assets/wrapper
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/functional/fixtures/.env | Updates GitLab Docker image tag to version 18.6.1-ee.0 |
| tests/functional/fixtures/docker-compose.yml | Updates entrypoint script path to match the new GitLab image structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5485137 to
7386870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7386870 to
55fb124
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
+ Coverage 95.72% 95.75% +0.03%
==========================================
Files 98 98
Lines 6052 6052
==========================================
+ Hits 5793 5795 +2
+ Misses 259 257 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@nejch It took a "few" iterations but I got things working. A review would be appreciated when you have some free time. Thanks in advance. |
55fb124 to
311a1af
Compare
311a1af to
d82d267
Compare
No description provided.