Skip to content

Conversation

@edmorley
Copy link
Contributor

This is based roughly on the steps used in #453.

This is based roughly on the steps used in #453.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ilevkivskyi
Copy link
Member

@edmorley Could you please sign the CLA (and don't forget to mention your GitHub account on b.p.o.)

@edmorley
Copy link
Contributor Author

edmorley commented Aug 15, 2017

Hi! Signing the CLA means providing personal details that I would rather not do if possible. The docs state that the CLA is only required for non-trivial changes, and since this only tweaks the README I think it could count as trivial?

@ilevkivskyi
Copy link
Member

The docs state that the CLA is only required for non-trivial changes, and since this only tweaks the README I think it could count as trivial?

I have no idea TBH. Let's ask @gvanrossum and @brettcannon

@brettcannon
Copy link
Member

Since this repository isn't under my purview I don't feel comfortable making a call, but since there isn't really any original thought going into the change (that's not meant to sound insulting, @edmorley , but it's what defines whether a signed CLA is necessary), it should be okay.

And what part of the CLA bothers you, @edmorley ? Is it providing your address to the PSF?

@gvanrossum
Copy link
Member

I think we should draw a hard line on the CLA. Open source is not conducted anonymously, that's not how you build trust in software that is widely used. Ed, the PSF will treat your information confidentially. (You may use the paper version of the CLA and mail or fax it in if you prefer.) If you still don't feel comfortable, that's fine too, we'll close the PR. Maybe someone else will come up with better instructions.

@edmorley
Copy link
Contributor Author

edmorley commented Aug 18, 2017

And what part of the CLA bothers you, @edmorley ? Is it providing your address to the PSF?

It was a combination of having to provide the address, allow third party cookies, whitelist a handful of adobe domains in NoScript etc. None of which were hard blockers, it just seemed easier to ask for the (documented) exception for trivial changes than to proceed at that point.

However I'm fine with signing if you'd prefer - and have just done so.

I think we should draw a hard line on the CLA. Open source is not conducted anonymously, that's not how you build trust in software that is widely used.

I agree that makes sense (if only since it removes the overhead of trying to decide what constitutes a trival change) - but it would be good for the docs to reflect that. If they had, I would have just signed the CLA from the outset. Once my CLA is processed, I'm happy to open a PR to fix the docs too (though feel free to do so yourself in the meantime if that's easier) :-)

@brettcannon
Copy link
Member

@edmorley Fixed the devguide: python/devguide@538b386

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@ilevkivskyi ilevkivskyi merged commit cc89ce8 into python:master Aug 18, 2017
@edmorley
Copy link
Contributor Author

@edmorley Fixed the devguide: python/devguide@538b386

Many thanks!

@edmorley edmorley deleted the wheels-workflow-docs branch August 22, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants