-
Notifications
You must be signed in to change notification settings - Fork 282
Document the workflow for publishing wheels #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is based roughly on the steps used in #453.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@edmorley Could you please sign the CLA (and don't forget to mention your GitHub account on b.p.o.) |
|
Hi! Signing the CLA means providing personal details that I would rather not do if possible. The docs state that the CLA is only required for non-trivial changes, and since this only tweaks the README I think it could count as trivial? |
I have no idea TBH. Let's ask @gvanrossum and @brettcannon |
|
Since this repository isn't under my purview I don't feel comfortable making a call, but since there isn't really any original thought going into the change (that's not meant to sound insulting, @edmorley , but it's what defines whether a signed CLA is necessary), it should be okay. And what part of the CLA bothers you, @edmorley ? Is it providing your address to the PSF? |
|
I think we should draw a hard line on the CLA. Open source is not conducted anonymously, that's not how you build trust in software that is widely used. Ed, the PSF will treat your information confidentially. (You may use the paper version of the CLA and mail or fax it in if you prefer.) If you still don't feel comfortable, that's fine too, we'll close the PR. Maybe someone else will come up with better instructions. |
It was a combination of having to provide the address, allow third party cookies, whitelist a handful of adobe domains in NoScript etc. None of which were hard blockers, it just seemed easier to ask for the (documented) exception for trivial changes than to proceed at that point. However I'm fine with signing if you'd prefer - and have just done so.
I agree that makes sense (if only since it removes the overhead of trying to decide what constitutes a trival change) - but it would be good for the docs to reflect that. If they had, I would have just signed the CLA from the outset. Once my CLA is processed, I'm happy to open a PR to fix the docs too (though feel free to do so yourself in the meantime if that's easier) :-) |
|
@edmorley Fixed the devguide: python/devguide@538b386 |
ilevkivskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
Many thanks! |
This is based roughly on the steps used in #453.