-
Notifications
You must be signed in to change notification settings - Fork 282
Bump version to 3.6.2 and use setuptools instead of distutils #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also update metadata to remove compatibility with 3.5+, and add Ivan to the list of authors.
|
I didn't find a root cause (though I suspect setuptools is being overly clever), but I found a work-around. It's unsatisfactory, but I managed to create wheels that seem to work by renaming the dist directory after each setup command, like this: rm -rf dist
python2 setup.py bdist_wheel
mv dist dist2
python3 setup.py bdist_wheel
mv dist dist3
python3 setup.py sdistAfter this I can move the wheels back into dist and run twine, but I'll hold off until someone has reviewed this procedure. Also the source dist created by the last step has way more files than the 3.6.1 source dist (I suspect setuptools here too). I propose to manually prune the tarball so it contains these files only: |
|
@gvanrossum hmm, this is odd. It's probably weird manifest.in stuff. I'd probably recommend creating a universal wheel that picks module at runtime. |
I had the same idea. At least IIRC I have seen other libs on PyPI do this. |
I get two different wheels and an sdist when I run: workon some3venv
rm -rf dist
python3 setup.py bdist_wheel
workon some2virtualenv
python2 setup.py bdist_wheel
python2 setup.py sdisteg: dist.tar.gz |
|
@gvanrossum can you repeat your problem in docker/vagrant/on travis ? |
|
I'm on OS X. All I know is that the sequence you use creates two identical
wheels, even in a clean checkout, both based on the first run. There much
be some caching going on. Maybe I'll just release the dist you just
attached, since it looks fine to me...
|
|
Try using Travis PyPI deploy |
I'm sorry I have no idea what that means (I'm not much of a Linux admin or devops person). Anyways I'm sure the problem is due to some setup on my system. I have to focus on other stuff first today. |
|
@gvanrossum create a new user on pypi.org eg "typing-bot" and give it maintainer access to then run through the steps here, with that user: |
|
I have no intention to let Travis install anything before I've built and tested the wheels. |
|
@gvanrossum you can configure it to point at the testing PyPI service, then promote the wheels |
|
Would you want to be our release manager?
|
Ah this appears to be due to: Adding an |
|
I could swear I had tried that, but apparently not, because it works. I will do the release now. |
|
OK, done. Someone please verify: https://pypi.python.org/pypi/typing/3.6.2 |
|
@ilevkivskyi When you approve of the release, can you merge this PR? |
|
Thanks! Everything works perfectly. |
|
Ah I guess the README section for releases needs updating too? |
|
@edmorley Yes, would you like to make a PR? |
This is based roughly on the steps used in #453.
Also update metadata to remove compatibility with 3.5+, and add Ivan
to the list of authors.
This is the version I intend to release as typing 3.6.2, except that I just found there's a problem with the py3 wheel -- it is identical to the py2 wheel. I'll try to debug.
In a sense this fixes #450 (I intend to release from this branch but we'll also have to merge the PR to get setup.py fixed in master).