Skip to content

Fix/py37#47

Merged
Chilipp merged 3 commits intodevelopfrom
fix/py37
Feb 13, 2022
Merged

Fix/py37#47
Chilipp merged 3 commits intodevelopfrom
fix/py37

Conversation

@Chilipp
Copy link
Member

@Chilipp Chilipp commented Jan 6, 2022 •
edited
Loading

This PR is a follow-up on #39 where we unfortunately broke compatibility with python 3.7...

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #47 (4f2c792) into develop (26e477b) will decrease coverage by 0.05%.
The diff coverage is 70.00%.

❗ Current head 4f2c792 differs from pull request most recent head 8dbd8c1. Consider uploading reports for the commit 8dbd8c1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #47      +/-   ##
===========================================
- Coverage    77.38%   77.33%   -0.06%     
===========================================
  Files           16       16              
  Lines         5802     5810       +8     
===========================================
+ Hits          4490     4493       +3     
- Misses        1312     1317       +5
Impacted Files Coverage Δ
psyplot/config/rcsetup.py 70.92% <33.33%> (-0.63%) ⬇️
psyplot/utils.py 78.28% <81.81%> (+0.27%) ⬆️
psyplot/__init__.py 71.42% <100.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e477b...8dbd8c1. Read the comment docs.

@Chilipp Chilipp changed the base branch from develop to master February 13, 2022 21:06
@Chilipp Chilipp changed the base branch from master to develop February 13, 2022 21:06
@Chilipp Chilipp merged commit 3448053 into develop Feb 13, 2022
@Chilipp Chilipp deleted the fix/py37 branch February 13, 2022 21:08
Chilipp added a commit that referenced this pull request Feb 13, 2022
@Chilipp
[semver:patch] plugin entrypoint compatibility fix for python 3.7 (#50)
5e62dfc 
Fix for compatibility with python 3.7 (#50)

Changed
------
* plugin entrypoint compatibility fix for python 3.7 (#47)
* ignore SNF links in linkcheck (#49)
* Replace gitter (#45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Chilipp