Conversation
Codecov Report
@@ Coverage Diff @@
## develop #39 +/- ##
===========================================
- Coverage 77.50% 77.49% -0.01%
===========================================
Files 16 16
Lines 5762 5782 +20
===========================================
+ Hits 4466 4481 +15
- Misses 1296 1301 +5
Continue to review full report at Codecov.
|
3 tasks
Chilipp
added a commit
that referenced
this pull request
Jan 5, 2022
Compatibility fixes and minor improvements, see #46 for full details. Added ----- - An abstract `convert_coordinate` method has been implemented for the `Plotter` and `Formatoption` class that can be used in subclasses to convert coordinates for the required visualization. The default implementation does nothing (see #39) Fixed ----- - the update method now only takes the coordinates that are dimensions in the dataset, see #39 - psyplot is now compatible with matplotlib 3.5 and python 3.10 Changed ------- - loading more than one variables into a `DataArray` now first selects the corresponding dimensions, then puts it into a single `DataArray`. This avoids loading the entire data (see #39)
Chilipp
added a commit
to psyplot/psy-simple
that referenced
this pull request
Feb 14, 2022
Compatibility fixes Changed ======= - We now use the new `convert_coordinate` method that has been introduced with psyplot v1.4.1 (see psyplot/psyplot#39 and #30) Fixed ===== - psy-simple is now compatible with matplotlib 3.5 (see #31)
Chilipp
added a commit
to psyplot/psy-maps
that referenced
this pull request
Feb 14, 2022
Fix projection issues Fixed ----- - `false_easting` and `false_northing` are now expected to be optional arguments for most projections (see #41) Changed ------- - we now use the `convert_coordinate` method that has been introduced in psyplot/psyplot#39 and psyplot/psy-simple#30. See #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small fix highlighted by #38. The update method for the dimensions uses the coordinates to select the default slices for dimensions. But it should only take the coordinates that are dimensions in the dataset...
closes #38
CHANGELOG.rstfor all changes