Skip to content

[ticket/15115] Update CSS error checking Stylelintrc file#4726

Closed
hanakin wants to merge 16 commits intophpbb:masterfrom
hanakin:ticket/15115
Closed

[ticket/15115] Update CSS error checking Stylelintrc file#4726
hanakin wants to merge 16 commits intophpbb:masterfrom
hanakin:ticket/15115

Conversation

@hanakin
Copy link
Member

@hanakin hanakin commented Mar 9, 2017

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

PHPBB3-15115

https://tracker.phpbb.com/browse/PHPBB3-15115

@hanakin hanakin closed this Mar 9, 2017
@hanakin hanakin reopened this Mar 9, 2017
@hanakin hanakin changed the title [ticket/15115] [ticket/15115] Update CSS error checking Stylelintrc file Mar 11, 2017
@CHItA CHItA added this to the 3.3.0-a1 milestone Mar 14, 2017
@CHItA CHItA requested review from CHItA and removed request for CHItA March 14, 2017 20:53
@marc1706
Copy link
Member

Sorry, fixing the merge conflict in the other PR I just merged caused a merge conflict here.

@hanakin
Copy link
Member Author

hanakin commented Mar 18, 2017

no worries should be good once test complete

@hanakin hanakin mentioned this pull request Mar 25, 2017
4 tasks
}

/* IE8 often can't handle max-width in %, so we use px instead */
/* IE8 often can"t handle max-width in %, so we use px instead */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fair this file needs deleted!

@hanakin
Copy link
Member Author

hanakin commented Mar 25, 2017

closed to restart travis

@hanakin hanakin closed this Mar 25, 2017
@hanakin hanakin reopened this Mar 25, 2017
marc1706 added a commit to marc1706/phpbb that referenced this pull request Mar 25, 2017
[ticket/15115] Update CSS error checking Stylelintrc file
marc1706 added a commit to marc1706/phpbb that referenced this pull request Mar 25, 2017
[ticket/15115] Update CSS error checking Stylelintrc file
@marc1706
Copy link
Member

There was an issue with the line endings in your last commit. Fixed that for you.

@marc1706
Copy link
Member

Merged via f36d569

@marc1706 marc1706 closed this Mar 25, 2017
@hanakin hanakin deleted the ticket/15115 branch May 17, 2017 14:58
@hanakin hanakin removed this from the 4.0.0-a1 milestone Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants