fix(linter/import/namespace): check namespace imports after named imports by camc314 · Pull Request #24094 · oxc-project/oxc

camc314 · 2026-07-02T20:36:59Z

Summary

continue checking later import entries when an earlier import is not a namespace
add regression coverage for import/namespace when a named import precedes an exported namespace import

Copilot

Pull request overview

Fixes a control-flow bug in the import/namespace linter rule where encountering a non-namespace (or non-resolvable) import entry would prematurely stop processing, causing later import entries in the same file to be skipped. Adds regression coverage for #24073 to ensure consistent diagnostics when a named import precedes a named import that resolves to an exported namespace (export * as).

Changes:

Replace several return early-exits in the per-import-entry loop with continue, allowing subsequent import entries to still be analyzed.
Add regression test cases for issue #24073 and update the snapshot output accordingly.
Add fixtures modeling export * as lib and a second named export used to reproduce the “earlier named import suppresses later namespace validation” scenario.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/import/namespace.rs	Fixes loop control-flow to keep checking later import entries; adds regression cases for #24073.
crates/oxc_linter/src/snapshots/import_namespace.snap	Updates expected diagnostics to cover the new regression fail cases.
crates/oxc_linter/fixtures/import/issue-24073/module.js	Adds a fixture that exports a namespace via `export * as lib` plus an additional named export.
crates/oxc_linter/fixtures/import/issue-24073/lib.js	Adds the underlying module used by the `export * as lib` fixture.

codspeed-hq · 2026-07-02T20:45:01Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks¹

_{Comparing codex/fix-import-namespace-order (cae2090) with main (e5a4162)²}

66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (30d17f5) during the generation of this report, so e5a4162 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

camc314 · 2026-07-02T21:37:46Z

Merge activity

Jul 2, 9:37 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 2, 9:37 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 2, 9:42 PM UTC: Merged by the Graphite merge queue.

…orts (#24094) ## Summary - continue checking later import entries when an earlier import is not a namespace - add regression coverage for import/namespace when a named import precedes an exported namespace import Fixes #24073

# Oxlint ### 🚀 Features - 7db7a29 allocator: Add `ReplaceWith` trait (#24012) (overlookmotel) - a2c97f3 linter/unicorn: Implement `explicit-timer-delay` rule (#23612) (Mikhail Baev) - 85735cb linter/unicorn: Implement `no-confusing-array-with` rule (#23638) (Shekhu☺️) - cb4fbb9 linter/eslint: Implement no-unreachable-loop rule (#23975) (Todor Andonov) - dc32112 linter/eslint/no-constant-binary-expression: Check relational comparisons (#24088) (camc314) - 439c344 linter/jsdoc: Added missing options to `jsdoc/require-param` rule (#23364) (kapobajza) - 62af717 linter/unicorn/filename-case: Add `lowercase` and `screamingSnakeCase` (#24045) (Boshen) - d963967 linter/unicorn/no-array-sort: Add `allowAfterSpread` option (#24043) (Boshen) - 0a75682 linter: Add per-rule timings for type-aware linting (#22488) (camchenry) - 743e222 linter/react: Add `disallowedValues` option for `forbid-dom-props` rule (#23970) (Mikhail Baev) ### 🐛 Bug Fixes - 7b80010 linter: Use direct binding symbol ids (#24216) (camc314) - 8f94b49 linter/import/no-duplicates: Don't flag a type-only import beside a side-effect import (#24030) (Boshen) - d8c3fee linter/react/rules-of-hooks: Flag `useEffectEvent` escapes (#23764) (Rayan Salhab) - 0a7312b linter/no-deprecated-functions: Map `require.requireActual` to `jest.requireActual` (#23627) (Jerry Zhao) - d9e3ab3 linter/eslint/no-useless-return: Handle switch case continuation (#23984) (camc314) - 0b25582 ast: Type binding node `typeAnnotation` as `TSTypeAnnotation | null` (#23113) (Boshen) - 122d112 linter/eslint/no-restricted-imports: Flag dynamic import() expressions (#24029) (Boshen) - 59b6b83 linter: Avoid `OnceLock` re-entry on cyclic `export *` re-exports (#23632) (Jerry Zhao) - dd09af0 linter/import/namespace: Avoid panic on destructuring of an unresolvable namespace re-export (#23626) (Jerry Zhao) - bdb51c7 linter/jest/prefer-ending-with-an-expect: Validate config patterns (#24122) (camc314) - e383843 linter/unicorn/prefer-modern-dom-apis: Skip fixer for non identifier arguments (#23630) (Jerry Zhao) - 0ac4c83 linter: Detect circular config extends (#24115) (camc314) - bae1edf linter/import/namespace: Check namespace imports after named imports (#24094) (camc314) - cd8fdfe linter/eslint/no-eval: Recognize Array.from family thisArg (#24091) (camc314) - 851ee43 linter/eslint/no-eval: Resolve this binding for functions returned from an IIFE (#23643) (Jerry Zhao) - 002ab35 linter/unicorn: Avoid prefer-array-find rest destructuring false positive (#23654) (ColemanDunn) - 01c8775 linter/unicorn/filename-case: Keep digits attached in screamingSnakeCase (#24056) (Boshen) - f256941 linter: Recognize `@effect/vitest` as a vitest import source (#24025) (Boshen) - 73eeb1d linter/import/extensions: Honor per-extension `never` for explicit extensions (#24031) (Boshen) - d4ebe1f linter: Reject non-object oxlint config files (#24026) (Boshen) - 45d607d linter/react/forbid-component-props: Make allow/disallow lists optional in schema (#24024) (Boshen) - 54076ad linter/unicorn/no-array-for-each: Suggest entries loop for index callbacks (#24004) (camc314) - d057736 linter/jsdoc: Avoid param root underflow (#23945) (camc314) - 29c76bf linter/unicorn/prefer-at: Skip object numeric-key access (#23909) (Gaurav Dubey) ### ⚡ Performance - 657a8fc linter/oxc/bad-array-method-on-arguments: Only run on member expressions instead of all identifiers (#24164) (camchenry) - 073d9e7 linter/eslint/prefer-rest-params: Run on functions instead of all identifiers (#24163) (camchenry) - e5a4162 linter/jest/no-confusing-set-timeout: Early exit fast path (#24092) (camc314) - bca7ce5 linter: Only run react-perf rules on JSX attribute nodes (#24083) (camchenry) - 6881bf6 linter: Compute `apply_overrides` rule set lazily (#23648) (Jerry Zhao) - 911c106 linter/eslint/no-obj-calls: Use resolved reference instead of scope walk (#23895) (Marius Schulz) - dc8fd9a linter/unicorn/prefer-dom-node-text-content: Change dispatch to run only on less common node types (#23897) (Connor Shea) - fdbd34d linter/eslint/no-useless-call: Fast-path static callees (#24077) (camc314) - b1be114 linter/import/extensions: Skip empty config and borrow extensions (#24075) (camc314) - 4781b2d linter/eslint/no-obj-calls: Use direct global matches (#24076) (camc314) - e6cee89 linter: Avoid node-chain allocation for non-Jest calls (#23907) (Yagiz Nizipli) - 30dc517 linter/typescript/no-restricted-types: O(1) banned-type lookups (#23827) (Yagiz Nizipli) ### 📚 Documentation - 6ca9125 linter/typescript: Clarify consistent-type-imports behavior (#23972) (camc314) # Oxfmt ### 🚀 Features - 4f4313e formatter_css: Update oxc-css-parser 0.0.5 (#24120) (leaysgur) - 0ccd8a1 formatter_graphql: Update oxc-graphql-parser 0.0.5 (#24106) (leaysgur) - 89ec3d9 formatter_core: Add literal line and root indention primitives (#24051) (leaysgur) - 213a96b formatter_core: Add no-expand-parent for multiline text (#24050) (leaysgur) - 0e5bcc9 formatter_graphql: Update oxc-graphql-parser 0.0.4 (#24039) (leaysgur) - e0b35a1 formatter_css: Update `oxc-css-parser@0.0.3` (#23974) (leaysgur) ### 🐛 Bug Fixes - 1fe6546 formatter: Omit unneeded `;` for type members with `no-semi` (#24212) (leaysgur) - 0ad7316 formatter: Print space for `ForStatement`.`update` only if exists (#24211) (leaysgur) - 3abbed5 formatter: Print `;` before jsdoc type-cast parens with no-semi (#24208) (leaysgur) - 9af3833 formatter_css: Make scss formatter consistent (#24207) (leaysgur) - 46d7194 formatter_css: Use fill IR for `@forward` members (#24206) (leaysgur) - e31038f formatter_css: Keep comment inside sass config list (#24205) (leaysgur) - d3b9591 formatter: Add parens around `await/yield` with `<T>` (#24202) (leaysgur) - 2121a55 oxfmt: Reuse tinypool process during the same LSP process (#24197) (leaysgur) - 9bf4b4a formatter_css: Align CSS output to Prettier 3.9.1 (#24100) (leaysgur) - cd2452e formatter_css: Align SCSS output to Prettier 3.9.1 (#24097) (leaysgur) - 4ee8745 formatter_css: Keep selector value contain line-break without breaking line (#24055) (leaysgur) - e1ece97 formatter_graphql: Break `implements` list by print-width (#23997) (leaysgur) - 0a6b16c formatter_json: Preserve key and literal value for json-stringify (#23996) (leaysgur) - 903ab6e formatter_css: Preserve newlines in css-in-js selector list (#23992) (leaysgur) - ea5d095 oxfmt: Update `--migrate prettier` (#23963) (leaysgur) ### ⚡ Performance - 468e1e3 formatter_core: Make printer queues cursor-based (#24098) (Boshen) - c59f2fe rust: Return impl ExactSizeIterator from slice-backed accessors (#24144) (Boshen) - c292fb2 formatter: Inline fits element dispatcher (#23982) (camc314) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

diegohaz · 2026-07-10T20:09:39Z

One possible side effect of this change: because import/namespace now continues past earlier import entries, it can expose the existing declaration-resolution false positive in #13258.

In this minimal reproduction, Oxlint 1.72.0 exits successfully because an earlier named import stops processing before the namespace import. Oxlint 1.73.0 reaches the namespace import and incorrectly reports a type-only export from the package's .d.ts entrypoint as missing:

https://github.com/diegohaz/oxlint-import-namespace-repro

So #24094 itself looks correct, but it changes which namespace references get validated and can surface #13258 in codebases that were previously clean.

Copilot AI review requested due to automatic review settings July 2, 2026 20:37

github-actions Bot added the A-linter Area - Linter label Jul 2, 2026

Copilot started reviewing on behalf of camc314 July 2, 2026 20:37 View session

camc314 mentioned this pull request Jul 2, 2026

linter: import/namespace inconsistently reports named imports #24073

Closed

Copilot AI reviewed Jul 2, 2026

View reviewed changes

camc314 self-assigned this Jul 2, 2026

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2026

graphite-app Bot force-pushed the codex/fix-import-namespace-order branch from cae2090 to bae1edf Compare July 2, 2026 21:38

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 2, 2026

graphite-app Bot merged commit bae1edf into main Jul 2, 2026
29 checks passed

graphite-app Bot deleted the codex/fix-import-namespace-order branch July 2, 2026 21:42

oxc-guard Bot mentioned this pull request Jul 6, 2026

release(apps): oxlint v1.73.0 && oxfmt v0.58.0 #24219

Merged

diegohaz mentioned this pull request Jul 10, 2026

linter: import/namespace reports an existing export as missing #13258

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter/import/namespace): check namespace imports after named imports#24094

fix(linter/import/namespace): check namespace imports after named imports#24094
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-import-namespace-order

camc314 commented Jul 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq Bot commented Jul 2, 2026

Uh oh!

camc314 commented Jul 2, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

diegohaz commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

camc314 commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq Bot commented Jul 2, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 commented Jul 2, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

diegohaz commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Jul 2, 2026 •

edited

Loading

camc314 commented Jul 2, 2026 •

edited by graphite-app Bot

Loading