Skip to content

adds both archive and beta pages for searching#170

Merged
jwittner merged 8 commits intomicrosoft:developfrom
StephenHodgson:dev-search-paths
Apr 26, 2019
Merged

adds both archive and beta pages for searching#170
jwittner merged 8 commits intomicrosoft:developfrom
StephenHodgson:dev-search-paths

Conversation

@StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Apr 19, 2019

Fixes #165
Fixes #167
Superceeds: #132

Copy link
Member

@jwittner jwittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big step in the right direction. Unfortunately it didn't seem to work for the latest alpha 2019.2.0a11, or the 2019.1.0f1. I fixed up the alpha search path, and added more that I'd recently discovered for f and b builds. Would love if you'd try out these changes @StephenHodgson and report here.

I've also modified the search to now look for any matching installer templates as well (the a/b don't have a link to UnitySetup with a version in the url) so I've dropped the special case for searching for the builtin_shaders. I'd like @Ziugy to review and try this out as well.

I did test my new changes with Get-OperatingSystem returning both Windows and Mac.

If @StephenHodgson and @Ziugy like these changes we'll move them in. If I didn't change the code I would have approved it myself. =)

@StephenHodgson
Copy link
Contributor Author

Awesome stuff @jwittner!

@jwittner
Copy link
Member

I merged this and #171 into master locally and tested Find-UnitySetupInstance and Get-UnitySetupInstance pretty thoroughly without issue. I'm going to move these in =).

@jwittner jwittner merged commit 31008bc into microsoft:develop Apr 26, 2019
@StephenHodgson StephenHodgson deleted the dev-search-paths branch April 26, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installer fails to find archives for release candidates without the a/b prefixes Find-UnitySetupInstaller reports an error searching for 2019.1.0b9

2 participants