Skip to content

Add support for alpha versions#132

Closed
TechoMan wants to merge 1 commit intomicrosoft:developfrom
TechoMan:patch-1
Closed

Add support for alpha versions#132
TechoMan wants to merge 1 commit intomicrosoft:developfrom
TechoMan:patch-1

Conversation

@TechoMan
Copy link

@TechoMan TechoMan commented Dec 16, 2018 •
edited
Loading

This PR shouldn't break any of existing features.

Example of version that is considered Invalid: 2019.1.0a10
Example of download link: https://unity3d.com/unity/alpha/2019.1.0a10
Example of exception that this PR should fix:

Exception setting "Version": "Cannot convert value "2019.1.0a10" to type "UnityVersion". Error: "Invalid unity version: 2019.1.0a10""
At C:\Users\Artem\Documents\WindowsPowerShell\Modules\UnitySetup\4.0.97\UnitySetup.psm1:128 char:9
+         $this.Version = $fileVersion
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
    + FullyQualifiedErrorId : ExceptionWhenSetting

@ArtemLavrentii
Add support for alpha versions
04e47ea 
This shouldn't break any of existing features
jwittner
jwittner requested changes Dec 19, 2018
View reviewed changes
Copy link
Member

@jwittner jwittner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! Thanks for pushing for more versions to be available through UnitySetup! =)

This change doesn't seem to be enough as it fails to find any components for the version you mention. There are several places that will need the 'a' added to 'fbp', and it looks like the link to the core component for alpha versions doesn't match the UnitySetup64-$version.exe naming scheme of the other download types.

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Jan 9, 2019

Any update to this?

@StephenHodgson StephenHodgson mentioned this pull request Apr 19, 2019
Merged
@StephenHodgson
Copy link
Contributor

StephenHodgson commented Apr 26, 2019

We can probably close this now, correct?

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Sep 27, 2019

@jwittner I think we can close this, I'm pretty sure the changes were superseded by #170

@jwittner jwittner closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwittner jwittner jwittner requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TechoMan @StephenHodgson @jwittner @ArtemLavrentii