Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Remove CSS example id attributes#556

Merged
wbamberg merged 1 commit into
mdn:masterfrom
danielhickman:remove-css-example-ids
Feb 7, 2018
Merged

Remove CSS example id attributes#556
wbamberg merged 1 commit into
mdn:masterfrom
danielhickman:remove-css-example-ids

Conversation

@danielhickman

@danielhickman danielhickman commented Feb 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

wbamberg
wbamberg approved these changes Feb 7, 2018
View reviewed changes

@wbamberg wbamberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome PR @danielhickman . I was just starting to think about removing these :).

@wbamberg wbamberg merged commit 8736d60 into mdn:master Feb 7, 2018
@danielhickman danielhickman deleted the remove-css-example-ids branch February 7, 2018 22:49
helmutgranda added a commit to helmutgranda/interactive-examples that referenced this pull request Feb 8, 2018
@helmutgranda
Fixed grammar and removed div IDs for each example to fulfill mdn#556 PR
471d0c8
@danielhickman

danielhickman commented Feb 8, 2018

Copy link
Copy Markdown
Contributor Author

#549 was merged with the IDs it seems.

wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request Feb 8, 2018
Merge remote-tracking branch 'upstream/master' into perspective
8d928fa 
* upstream/master:
  Adding list-style css example. (mdn#547)
  Flex examples (mdn#558)
  Add column examples (mdn#549)
  Remove CSS example id attributes (mdn#556)
  Add various text examples (mdn#545)
  Add contribution item (mdn#552)
  Adds @helmutgranda as contributor (mdn#550)
  Adding border radius example with recommended changes. (mdn#546)
  Add `quotes` example (mdn#543)
@wbamberg

wbamberg commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

@danielhickman , I can take care of #549 .

@wbamberg wbamberg mentioned this pull request Feb 8, 2018
Merged
wbamberg pushed a commit that referenced this pull request Feb 9, 2018
@helmutgranda
Adding supporrting samples for border corners to support request #502 (…
56918fd 
…#553)

* Adding supporrting samples for border corners to support request #502

* Fixed grammar and removed div IDs for each example to fulfill #556 PR

* Moving styles to have only one dependency, and deleted border-radius-corner.css. Meta updated as well.
@veekas veekas mentioned this pull request Feb 9, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wbamberg wbamberg wbamberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielhickman @wbamberg