This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Adding border radius example with recommended changes.#546
Merged
Conversation
wbamberg
suggested changes
Feb 6, 2018
wbamberg
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates! Looks great, but I had a couple more minor comments.
| <div class="example-choice" initial-choice="true"> | ||
| <pre><code id="example_one" class="language-css">border-radius: 30px;</code></pre> | ||
| <button type="button" class="copy hidden" aria-hidden="true"> | ||
| <span class="visually-hidden">Copy to Clipboard</span> |
Contributor
There was a problem hiding this comment.
Please indent HTML using 4 spaces, not 8 (here and elsewhere in this file).
| @@ -0,0 +1,7 @@ | |||
| #example-element { | |||
| width: 200px; | |||
Contributor
There was a problem hiding this comment.
I think we should use something like width: 80%; here - as it is this cuts off the end of the text.
wbamberg
approved these changes
Feb 6, 2018
wbamberg
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution @helmutgranda !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
wbamberg
pushed a commit
to wbamberg/interactive-examples
that referenced
this pull request
Feb 8, 2018
* upstream/master: Adding list-style css example. (mdn#547) Flex examples (mdn#558) Add column examples (mdn#549) Remove CSS example id attributes (mdn#556) Add various text examples (mdn#545) Add contribution item (mdn#552) Adds @helmutgranda as contributor (mdn#550) Adding border radius example with recommended changes. (mdn#546) Add `quotes` example (mdn#543)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new PR with changes recommended by @wbamberg for #502