[RFC] adding --raw option for screenshots and adding generic plugins for png and bmp - #124
Open
dariuskt wants to merge 2 commits into
Open
[RFC] adding --raw option for screenshots and adding generic plugins for png and bmp#124dariuskt wants to merge 2 commits into
dariuskt wants to merge 2 commits into
Conversation
Contributor
|
Sorry for my late response but I'm a bit tied up at the moment. I'll work my way through this PR as soon as possible. Regarding the --port option. Technically you can just add --port with no equivalent short option. I think that would be acceptable. |
Author
|
hey, do you have any estimate when you would be able to look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request For Comments
It's kinda two things in same PR but i could not test one without the other, so together they go.
.regex = "lxi-tools/bmp"and.regex = "lxi-tools/png"command = "display:data? BMP\n";andcommand = "display:data? PNG\n";rigol-1000zandsiglent-sdgstill works toothis would solve #122 and #123