Skip to content

[RFC] adding --raw option for screenshots and adding generic plugins for png and bmp - #124

Open
dariuskt wants to merge 2 commits into
lxi-tools:masterfrom
dariuskt:master
Open

[RFC] adding --raw option for screenshots and adding generic plugins for png and bmp#124
dariuskt wants to merge 2 commits into
lxi-tools:masterfrom
dariuskt:master

Conversation

@dariuskt

@dariuskt dariuskt commented Sep 9, 2025

Copy link
Copy Markdown

Request For Comments

It's kinda two things in same PR but i could not test one without the other, so together they go.

  1. Added --raw option for screenshots just like scpi and benchmark already has.
  • had to modify all plugins and screenshots and gui as i needed to propagate port and protocol everywhere
  • would like to add --port too, but screenshots already has -p used up for --plugin and I would like consistency with other commands. maybe give plugin some other short arg like -d / --device ?
  1. Added generic screenshot plugins for png and bmp. let me know if you want other keywords or command.
  • .regex = "lxi-tools/bmp" and .regex = "lxi-tools/png"
  • command = "display:data? BMP\n"; and command = "display:data? PNG\n";
  1. Testing
  • new generic plugins works
  • rigol-1000z and siglent-sdg still works too
  • could not test gui as i have no machine to run it, but it compiles with no errors and no extra warnings as far as i can tell.

this would solve #122 and #123

@lundmar

lundmar commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Sorry for my late response but I'm a bit tied up at the moment. I'll work my way through this PR as soon as possible.

Regarding the --port option. Technically you can just add --port with no equivalent short option. I think that would be acceptable.

@dariuskt

Copy link
Copy Markdown
Author

hey, do you have any estimate when you would be able to look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants