Skip to content

fix(read): reject fractional PDF page ranges #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LI-Jialu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(read): reject fractional PDF page ranges #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50b974
fix(read): reject fractional PDF page ranges
LI-Jialu Jun 30, 2026
e783c1b
test(read): cover fractional PDF page ranges
LI-Jialu Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/core/src/tests/tool-handlers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,22 @@ test("Read returns an acknowledgement for images and attaches the image as a fol
);
});

test("Read rejects fractional PDF page ranges", async () => {
const workspace = createTempWorkspace();
const filePath = path.join(workspace, "sample.pdf");
fs.writeFileSync(filePath, makePdfWithPages(4), "utf8");

for (const pages of ["1.9", "2.1-3.9"]) {
const readResult = await handleReadTool(
{ file_path: filePath, pages },
createContext("pdf-fractional-pages", workspace)
);

assert.equal(readResult.ok, false);
assert.match(readResult.error ?? "", /must be an integer/);
}
});

function createContext(
sessionId: string,
projectRoot: string,
Expand All @@ -1024,6 +1040,11 @@ function createTempWorkspace(): string {
return dir;
}

function makePdfWithPages(pageCount: number): string {
const pages = Array.from({ length: pageCount }, (_, index) => `${index + 1} 0 obj << /Type /Page >> endobj`);
return ["%PDF-1.4", ...pages, "%%EOF", ""].join("\n");
}

async function readSnippet(
filePath: string,
sessionId: string,
Expand Down
8 changes: 5 additions & 3 deletions packages/core/src/tools/read-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,11 +552,13 @@ function parsePositiveInt(value: string, label: string): number {
if (!Number.isFinite(numeric)) {
throw new Error(`${label} must be a number.`);
}
const integer = Math.trunc(numeric);
if (integer < 1) {
if (!Number.isInteger(numeric)) {
throw new Error(`${label} must be an integer.`);
}
if (numeric < 1) {
throw new Error(`${label} must be >= 1.`);
}
return integer;
return numeric;
}

function readNotebook(filePath: string): string {
Expand Down