fix(read): reject fractional PDF page ranges#210
Open
LI-Jialu wants to merge 2 commits into
Open
Conversation
Add a regression test for rejecting fractional PDF page ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject fractional PDF page ranges instead of silently truncating them.
Before this change,
pages: "1.9"was accepted as page1, andpages: "2.1-3.9"was accepted as2-3. Page ranges should be positive integers, so fractional values now return a validation error.Testing
cd packages/core/src/tests && node --import tsx --test tool-handlers.test.tsnpm run format:check -- packages/core/src/tools/read-handler.ts packages/core/src/tests/tool-handlers.test.tsnpm run typecheck --workspace @vegamo/deepcode-core