Fix for empty string format - #1112
Conversation
999 fix empty string response
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| export function echo(...args: any[]): void | ||
| export function echo(pieces: TemplateStringsArray, ...args: any[]) { | ||
| const lastIdx = pieces.length - 1 | ||
| console.log(isStringLiteral(pieces, ...args)) |
There was a problem hiding this comment.
Debug point should be removed.
| ? arg.toString().trimEnd() | ||
| : arg === '' | ||
| ? `${''}` | ||
| : `${arg}` |
There was a problem hiding this comment.
Provide a test for this case.
There was a problem hiding this comment.
I don't think this is a right place for this fix. It should be done in quote function.
There was a problem hiding this comment.
Hey @antonmedv . When you say quote function, is it the one on core.ts?
| ? arg.toString().trimEnd() | ||
| : arg === '' | ||
| ? `${''}` | ||
| : `${arg}` |
There was a problem hiding this comment.
I don't think this is a right place for this fix. It should be done in quote function.
closes google#999 closes google#1112
closes google#999 closes google#1112
Fixes #<number_goes_here>