Skip to content

Chore/readme grammar - #1

Merged
antonmedv merged 3 commits into
google:mainfrom
thescientist13:chore/readme-grammar
May 7, 2021
Merged

Chore/readme grammar#1
antonmedv merged 3 commits into
google:mainfrom
thescientist13:chore/readme-grammar

Conversation

@thescientist13

Copy link
Copy Markdown
Contributor

Fixes N / A

Just a couple small, minor grammar tweaks in the README.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

I tried to run tests just to be safe, but yarn test and npm run test both failed for me with

% npm run test

> zx@1.0.2 test /Users/owenbuckley/Workspace/github/forks/zx
> zx test.mjs

sh: zx: command not found

Couldn't find any notes in contributing.md but let me know if there is anything else you need.

@wadie

wadie commented May 6, 2021

Copy link
Copy Markdown

Also remove the s in languages on line 21. 😅

people usually choose a more convenient programming languages.

@azu azu mentioned this pull request May 7, 2021
2 tasks
@antonmedv

Copy link
Copy Markdown
Collaborator

Hi 👋, thanks for proofreading))
Please, head over to https://cla.developers.google.com/ to sign CLA.

@antonmedv
antonmedv merged commit 4238bf0 into google:main May 7, 2021
@antonmedv antonmedv mentioned this pull request May 7, 2021
2 tasks
@thescientist13
thescientist13 deleted the chore/readme-grammar branch May 7, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants