Skip to content

Deploy Dec 13, 2018 - JS Tracer#1558

Merged
gregtatum merged 29 commits into
productionfrom
master
Dec 13, 2018
Merged

Deploy Dec 13, 2018 - JS Tracer#1558
gregtatum merged 29 commits into
productionfrom
master

Conversation

@gregtatum

Copy link
Copy Markdown
Member
  • Allow focus to move from the search field when there's text in it
  • Fix network marker timing
  • Arrow panel accessibility fix
  • Make shrinking of the top bar behave nicer
  • JS Tracer

brisad and others added 29 commits December 4, 2018 20:14
…espace when integrating threads during profile processing, and add an upgrader to fix this mistake on existing processed profiles.
name, dur and title are properties of TracingMarker, not of the payload that is
inside the tracing marker. RedirectURI is optional.

Here's the code that writes out the payload to the JSON:
https://searchfox.org/mozilla-central/rev/9abd7f512c9b29071776e7ba3f991d5b5fd59ff6/tools/profiler/core/ProfilerMarkerPayload.cpp#164-201
…1546)

This PR contains four changes:

 1. Add a network marker to the profiling upgrading fixtures
 2. Fix the timestamps during processing and add an upgrader.
 3. Fix the flow types for Network marker payloads.
 4. Add a test for marker time shifting during profile processing.
When using only the opacity, the panel is visible from the accessibility
tree. Using `visibility: hidden` at the right place hides it when it's closed.
An upcoming commit will hide the tab when there is no JS tracer
information available.
@codecov

codecov Bot commented Dec 13, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1558 into production will increase coverage by 0.19%.
The diff coverage is 86.85%.

Impacted file tree graph

@@              Coverage Diff               @@
##           production    #1558      +/-   ##
==============================================
+ Coverage       81.29%   81.48%   +0.19%     
==============================================
  Files             160      166       +6     
  Lines           11120    11555     +435     
  Branches         2744     2837      +93     
==============================================
+ Hits             9040     9416     +376     
- Misses           1883     1938      +55     
- Partials          197      201       +4
Impacted Files Coverage Δ
src/app-logic/tabs-handling.js 100% <ø> (ø) ⬆️
src/components/app/ProfileViewer.js 80% <ø> (ø) ⬆️
src/components/sidebar/index.js 100% <ø> (ø) ⬆️
src/types/actions.js 0% <ø> (ø) ⬆️
src/test/fixtures/profiles/gecko-profile.js 100% <ø> (ø) ⬆️
src/components/app/Details.js 50% <ø> (ø) ⬆️
src/app-logic/url-handling.js 82.5% <0%> (-1.26%) ⬇️
src/components/app/MenuButtons.js 44.56% <100%> (ø) ⬆️
src/utils/flow.js 81.66% <100%> (+0.31%) ⬆️
src/components/js-tracer/Settings.js 100% <100%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119c0f5...866bab7. Read the comment docs.

@gregtatum gregtatum merged commit 01e72c3 into production Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants