Deploy Dec 13, 2018 - JS Tracer#1558
Merged
Merged
Conversation
gregtatum
commented
Dec 13, 2018
Member
- Allow focus to move from the search field when there's text in it
- Fix network marker timing
- Arrow panel accessibility fix
- Make shrinking of the top bar behave nicer
- JS Tracer
…espace when integrating threads during profile processing, and add an upgrader to fix this mistake on existing processed profiles.
name, dur and title are properties of TracingMarker, not of the payload that is inside the tracing marker. RedirectURI is optional. Here's the code that writes out the payload to the JSON: https://searchfox.org/mozilla-central/rev/9abd7f512c9b29071776e7ba3f991d5b5fd59ff6/tools/profiler/core/ProfilerMarkerPayload.cpp#164-201
…1546) This PR contains four changes: 1. Add a network marker to the profiling upgrading fixtures 2. Fix the timestamps during processing and add an upgrader. 3. Fix the flow types for Network marker payloads. 4. Add a test for marker time shifting during profile processing.
When using only the opacity, the panel is visible from the accessibility tree. Using `visibility: hidden` at the right place hides it when it's closed.
An upcoming commit will hide the tab when there is no JS tracer information available.
Codecov Report
@@ Coverage Diff @@
## production #1558 +/- ##
==============================================
+ Coverage 81.29% 81.48% +0.19%
==============================================
Files 160 166 +6
Lines 11120 11555 +435
Branches 2744 2837 +93
==============================================
+ Hits 9040 9416 +376
- Misses 1883 1938 +55
- Partials 197 201 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.