Fix network marker timings timestamps#1546
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=========================================
- Coverage 81.31% 81.2% -0.11%
=========================================
Files 160 160
Lines 11119 11164 +45
Branches 2746 2766 +20
=========================================
+ Hits 9041 9066 +25
- Misses 1881 1892 +11
- Partials 197 206 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 81.31% 81.36% +0.05%
==========================================
Files 160 160
Lines 11119 11163 +44
Branches 2746 2764 +18
==========================================
+ Hits 9041 9083 +42
- Misses 1881 1883 +2
Partials 197 197
Continue to review full report at Codecov.
|
…espace when integrating threads during profile processing, and add an upgrader to fix this mistake on existing processed profiles.
name, dur and title are properties of TracingMarker, not of the payload that is inside the tracing marker. RedirectURI is optional. Here's the code that writes out the payload to the JSON: https://searchfox.org/mozilla-central/rev/9abd7f512c9b29071776e7ba3f991d5b5fd59ff6/tools/profiler/core/ProfilerMarkerPayload.cpp#164-201
e687bc1 to
aaf0e45
Compare
gregtatum
approved these changes
Dec 10, 2018
gregtatum
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains four changes:
I recommend reviewing the individual commits.