Split model into port and evaluator structs#169
Open
icewind1991 wants to merge 8 commits into
Open
Conversation
icewind1991
force-pushed
the
pin-structs
branch
from
December 12, 2025 17:23
f321060 to
2f680b5
Compare
icewind1991
force-pushed
the
pin-structs
branch
from
December 12, 2025 17:26
43cead1 to
d071c16
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
pin-structs
branch
from
December 12, 2025 18:51
1c20828 to
15c8aec
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
pin-structs
branch
from
December 12, 2025 18:58
15c8aec to
f3dabcc
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Author
|
Re-added support for wide ports |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Author
|
All features should work again, examples and documentation is updated. So this should be good for review now. |
icewind1991
marked this pull request as ready for review
December 21, 2025 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo:
The port structs interface directly with state in the verilator model
Async runtime implementation made possible with this api: https://codeberg.org/icewind/marlin_async/src/branch/pin-structs
The main api different for users not doing anything fancy is doing
model.input_port.set(1)instead ofmodel.input_port = 1andlet val = model.output_port.get()instead oflet val = model.output_port.In exchange we get the port direction enforced by the type system and the ability to split the model into separate parts and move individual pins into higher level constructs.
An example of a higher level construct this makes possible is:
that can then be used as a high level api for reading serial output from a model while being free to touch the other ports independently.