Shutdown and termination sig handling by ShoroukRamzy · Pull Request #15 · eclipse-score/feo

ShoroukRamzy · 2025-11-11T14:18:00Z

This is a continuation for this PR #12.
As per our discussion in the meeting this commit is not working after rebasing due to ctrlc issue.

Thank you for your support.

github-actions · 2025-11-11T14:19:01Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 2f1ca830-7072-48ad-957f-7e6168ce3856
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-iKHWUIBrUN/fFOCltkTmHfDcKw0h4ZVmP7NVSoc8zBs="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (84 packages loaded, 9 targets configured)

Analyzing: target //:license-check (89 packages loaded, 13 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2602 targets configured)

Analyzing: target //:license-check (156 packages loaded, 6864 targets configured)

INFO: Analyzed target //:license-check (159 packages loaded, 8880 targets configured).
[8 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 19.776s, Critical Path: 0.43s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2025-11-11T14:20:01Z

The created documentation from the pull request is available at: docu-html

armin-acn · 2025-11-12T09:42:23Z

Hi @ShoroukRamzy, I think the problem is that the crate ctrlc is not part of the score-crates repo. This is where bazel looks for external crates. I will test it locally and let you know. Otherwise, you can also try on your side.

ShoroukRamzy · 2025-11-12T15:05:11Z

Hi @ShoroukRamzy, I think the problem is that the crate ctrlc is not part of the score-crates repo. This is where bazel looks for external crates. I will test it locally and let you know. Otherwise, you can also try on your side.

Hi @armin-acn, I have opened this PR to add ctrlc to score crates eclipse-score/score-crates#15?
Thanks!

armin-acn · 2025-11-12T16:37:10Z

Approved it.

ShoroukRamzy · 2025-11-12T17:01:14Z

Approved it.

Thanks @armin-acn, I'll retest after the PR merge.

armin-acn · 2025-11-13T09:30:25Z

Hi @ShoroukRamzy, would it be a problem for you, if the very first Release of FEO v0.5 (to be prepared until tomorrow the latest) would not include this PR? We can probably create a minor release update very soon, which could then include your changes.

ShoroukRamzy · 2025-11-13T09:46:44Z

Hi @ShoroukRamzy, would it be a problem for you, if the very first Release of FEO v0.5 (to be prepared until tomorrow the latest) would not include this PR? We can probably create a minor release update very soon, which could then include your changes.

Hi @armin-acn, Yes, sure. We can do this.

ShoroukRamzy · 2025-11-13T12:05:56Z

Hi @armin-acn,
I have several linter issues due to using std lib, seems there is a limitation of using the std lib? if my understanding is correct, Do i need to apply changes to the whole code to pass CI?
Thanks!

armin-acn · 2025-11-13T17:03:04Z

Hi Shorouk, you should not need to change the existing code, as it did pass the linter. But from your last commit it looks like you are already progressing.

ShoroukRamzy · 2025-11-13T21:11:50Z

Hi @armin-acn,
The design documentation for this feature, detailing the proposed shutdown sequence, is now available for review at feo/Design/shutdown_sequence.md. Please let me know your feedback.
Thanks in advance!

artemsheinacn · 2025-11-17T09:36:07Z

BUILD

 copyright_checker(
    name = "copyright",
    srcs = [
-        "src",


Why is this needed?

as src dir is empty after feo migration, I removed it. do I need to keep it?

Which src dir do you mean? I guess it checks every src dir in the repository, but I don't know for sure how it works.

https://github.com/eclipse-score/feo/tree/main/src this one I mean

Ok, I don't think it's related to this directory only. Let's not change it in this commit as the change is unrelated.

artemsheinacn · 2025-11-17T09:37:13Z

examples/rust/mini-adas/Cargo.toml

 default = ["com_iox2", "signalling_relayed_tcp"]
 signalling_direct_mpsc = []
-signalling_direct_tcp = []
+signalling_direct_tcp = ["com_iox2"]


Thanks , you are right I added it during direct signalling testing but there is no need for it, I will remove it

artemsheinacn · 2025-11-17T09:50:47Z

feo/src/scheduler.rs

                    }
                    break id;
                }
+                Some(Signal::TerminateAck(_)) => continue, // Ignore during normal operation


Why ignoring unexpected signal without logging?

Thanks, I will add logging info

artemsheinacn

LGTM

* Implement graceful shutdown and termination signalling * ctrlc is not built after rebasing * fixed ctrlc(score_crates) issue * use alloc and core libs instead of std whenever possible

ShoroukRamzy force-pushed the shutdown_and_termination_sig_handling branch 5 times, most recently from 8f8421b to 999c8dd Compare November 12, 2025 09:20

ShoroukRamzy mentioned this pull request Nov 12, 2025

handling shutdown and termination signallingin [all signalling modes] #12

Closed

ShoroukRamzy mentioned this pull request Nov 12, 2025

add ctrlc crate for FEO shutdown feature eclipse-score/score-crates#15

Merged

ShoroukRamzy added 3 commits November 13, 2025 22:29

Implement graceful shutdown and termination signalling

206a81d

ctrlc is not built after rebasing

d80b49f

fixed ctrlc(score_crates) issue

456a32e

ShoroukRamzy force-pushed the shutdown_and_termination_sig_handling branch 2 times, most recently from 264e241 to c2beeca Compare November 13, 2025 20:56

artemsheinacn reviewed Nov 17, 2025

View reviewed changes

ShoroukRamzy force-pushed the shutdown_and_termination_sig_handling branch from c2beeca to c22bffd Compare November 17, 2025 10:48

use alloc and core libs instead of std whenever possible

0363e7c

ShoroukRamzy force-pushed the shutdown_and_termination_sig_handling branch from c22bffd to 0363e7c Compare November 17, 2025 10:59

artemsheinacn approved these changes Nov 17, 2025

View reviewed changes

armin-acn approved these changes Nov 17, 2025

View reviewed changes

armin-acn merged commit ca1f4c9 into eclipse-score:main Nov 17, 2025
8 checks passed

ShoroukRamzy mentioned this pull request Nov 18, 2025

Shutdown sequence Implementation proposal #7

Closed

Conversation

ShoroukRamzy commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

armin-acn commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShoroukRamzy commented Nov 12, 2025

Uh oh!

armin-acn commented Nov 12, 2025

Uh oh!

ShoroukRamzy commented Nov 12, 2025

Uh oh!

armin-acn commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShoroukRamzy commented Nov 13, 2025

Uh oh!

ShoroukRamzy commented Nov 13, 2025

Uh oh!

armin-acn commented Nov 13, 2025

Uh oh!

ShoroukRamzy commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artemsheinacn Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artemsheinacn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 11, 2025 •

edited

Loading

armin-acn commented Nov 12, 2025 •

edited

Loading

armin-acn commented Nov 13, 2025 •

edited

Loading

ShoroukRamzy commented Nov 13, 2025 •

edited

Loading

artemsheinacn Nov 17, 2025 •

edited

Loading