Fix CI: replace decommissioned vs2022preview pool image [vs17.12] - #13541
Conversation
The windows.vs2022preview.amd64.open image on the NetCore-Public pool has been decommissioned, causing the FullReleaseOnWindows job to hang and time out. Replace with the actively maintained windows.vs2022.amd64.open stable image. Bump version 17.12.58 -> 17.12.59 (required for servicing branch PRs). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the servicing-branch CI configuration to stop using a decommissioned Windows VS2022 Preview agent image and bumps the patch version to satisfy servicing-branch requirements.
Changes:
- Switch
FullReleaseOnWindows(public pool) fromwindows.vs2022preview.amd64.opentowindows.vs2022.amd64.opento restore agent availability. - Bump
VersionPrefixfrom17.12.58to17.12.59.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eng/Versions.props |
Patch version bump for the servicing branch. |
.vsts-dotnet-ci.yml |
Update pool demand to use the maintained VS2022 stable image for the affected CI job. |
There was a problem hiding this comment.
Review Summary — PR #13541
Reviewed: Both changes in .vsts-dotnet-ci.yml and eng/Versions.props.
CI Pool Image Change (windows.vs2022preview → windows.vs2022)
✅ Looks correct. This is the only ImageOverride reference in .vsts-dotnet-ci.yml, and no other files in the repo reference vs2022preview — so there are no missed occurrences. The FullReleaseOnWindows job for the public pool now targets the stable VS 2022 image, which is consistent with the other pipeline files (e.g., eng/common/core-templates/post-build/post-build.yml already uses windows.vs2022.amd64).
For a servicing branch (vs17.12), using the stable image rather than preview is the right call — it reduces risk of unexpected toolchain changes destabilizing release builds and aligns with the principle of using well-known, stable infrastructure for servicing.
Version Bump (17.12.58 → 17.12.59)
✅ Standard patch-level servicing bump. Only the patch component changes, DotNetFinalVersionKind remains release, and no other version-related properties are affected. This is consistent with the expected servicing workflow.
No Issues Found
Both changes are straightforward, low-risk, and consistent with the repo's conventions. No functional, correctness, or security concerns identified.
Note
🔒 Integrity filter blocked 1 item
The following item were blocked because they don't meet the GitHub integrity level.
- #13541
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
To allow these resources, lower min-integrity in your GitHub frontmatter:
tools:
github:
min-integrity: approved # merged | approved | unapproved | noneGenerated by Expert Code Review (on open) for issue #13541 · ● 1.2M
ViktorHofer
left a comment
There was a problem hiding this comment.
Agreed. We shouldn't be using the preview windows pool in servicing.
Why didn't the image change merge forward? |
If the bot is to be trusted, this is a series of issues that was bubbling for a while:
So it's not really "stalled" — both mechanisms tried and both got blocked: the merge-forward by a bot-commit filter, and |
Yes that's a known issue and it's super annoying. It affects multiple repos. |
Problem
The
FullReleaseOnWindowsCI job uses thewindows.vs2022preview.amd64.openimage on theNetCore-Publicpool. This image has been decommissioned by the dnceng infrastructure team (see dotnet/dnceng#6396), causing the job to hang waiting for an agent and eventually time out after 3 hours.This has been broken since approximately Feb-Mar 2026 (last known working PR: Jan 26, first known broken: Apr 6).
Fix
Replace
windows.vs2022preview.amd64.openwithwindows.vs2022.amd64.open(the stable VS 2022 image that is actively maintained). This is the same image used by the vs17.8 servicing branch which continues to work.The
mainbranch useswindows.vs2026preview.scout.amd64.openbut that targets a newer VS version not appropriate for 17.x servicing branches.Changes
.vsts-dotnet-ci.yml: Update pool image demand forFullReleaseOnWindowsjobeng/Versions.props: Bump patch version (required for servicing branch PRs)