Skip to content

feat(hubble): use fixed domain for hubble api #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaeddine-13 merged 3 commits into from
May 19, 2022
Merged

feat(hubble): use fixed domain for hubble api #349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de167c1
feat(hubble): use fixed domain for hubble api
mapleeit May 19, 2022
9b4977e
fix: address comment
mapleeit May 19, 2022
856e5e1
fix: address comments again
mapleeit May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions docarray/array/mixins/io/pushpull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,11 @@ def _get_hub_config() -> Optional[Dict]:

@lru_cache()
def _get_cloud_api() -> str:
"""Get Cloud Api for transmiting data to the cloud.
"""Get Cloud Api for transmitting data to the cloud.

:raises RuntimeError: Encounter error when fetching the cloud Api Url.
:return: Cloud Api Url
"""
if 'JINA_HUBBLE_REGISTRY' in os.environ:
u = os.environ['JINA_HUBBLE_REGISTRY']
else:
try:
req = Request(
'https://api.jina.ai/hub/hubble.json',
headers={'User-Agent': 'Mozilla/5.0'},
)
with urlopen(req) as resp:
u = json.load(resp)['url']
except Exception as ex:
raise RuntimeError(
f'Can not fetch Cloud API address from {req.full_url}'
) from ex

return u
return os.environ.get('JINA_HUBBLE_REGISTRY', 'https://api.hubble.jina.ai')


class PushPullMixin:
Expand Down